-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with flaky tests #1755
Comments
Two more in the same run:
|
Three more in the same run:
|
Again, and again.
|
One more time:
|
Here we go again:
|
https://github.com/FuelLabs/fuels-ts/actions/runs/8002556292/job/21858435060?pr=1789
|
Would be interesting to see if we can prove these working with #1356 where parallel txs wouldn't be an issue. |
https://github.com/FuelLabs/fuels-ts/actions/runs/8230682592/job/22504434996?pr=1846#step:9:207
|
https://github.com/FuelLabs/fuels-ts/actions/runs/8472514511/job/23214781407?pr=1972#step:9:101
|
Another one https://github.com/FuelLabs/fuels-ts/actions/runs/8615957986/job/23628036102?pr=2030#step:9:620
|
@nedsalk Regarding the above error — is it related to the stream parsing logic? @Torres-ssf Is this the same stream issue you mentioned you had? |
The same error happens here as well:
|
Given many of these flakey tests seem related to the predicates on the e2e workflow, I think until #1820 is ready we can have a temporary fix by adding delays. |
Also https://github.com/FuelLabs/fuels-ts/actions/runs/8878299585/job/24373658684#step:10:699 FAIL apps/docs-snippets/src/guide/transactions/transaction-response.test.ts > Transaction Response > gets transaction response from tx id
Error: Transaction is not inserted. UTXO does not exist: 0xbadeb64d29717433856a595ebd3d620af82711e4177d467dfd5b92f03acbfc750000: {"response":{"data":null,"errors":[{"message":"Transaction is not inserted. UTXO does not exist: 0xbadeb64d29717433856a595ebd3d620af82711e4177d467dfd5b92f03acbfc750000","locations":[{"line":2,"column":3}],"path":["submit"]}],"status":200,"headers":{}},"request":{"query":"mutation submit($encodedTransaction: HexString!) {\n submit(tx: $encodedTransaction) {\n id\n }\n}","variables":{"encodedTransaction":"0x000000000000000000000000000004d00000000000000000000000000000000000000000000000000000000000000000000000000000019c000000000000000100000000000000090000000000000001000000000000000100000000000000011af0300074000002000000000000017c5dffc00110ffff001aec5000910000985057b0586140000a1b441000104104405c4100005c47f000105904405c43f008154164007640004c5d43f002264000001a4070005fed00105d43f0025fed00115fec00125043b0805d47b0105d4bb0115d4fb012104d3040165124c076500001135124c0765000065047b0285fec0005504fb06872480018284d14807400000c124d3480104d30401b4d24c0264c0000281d14801a4470005fec10005fed10015fed3002504fb06872440018284fb4405047b04072480018284534805d47b00d134510007644000f5d47b00813451040764400025d43f003364000005047b04050451008504bb0405049200850492008724c0008284114c050450008724c0008284524c05d4500005d4900021b481480104514805e4560005d450002104510405f4110025043b08050450010504bb018724c0008284904c050412008724c0008284114c072400010285524005d4150015d55500025550000360000000a00000000000000ff000000000000000000000000000400cccccccccccc0002000000000100000000000000000000000000000000000000000004640000000000000000badeb64d29717433856a595ebd3d620af82711e4177d467dfd5b92f03acbfc750000000000000000d775b4fb1198695e4e6fb37e3a2f25dc5027e3572d6f139b68720bfa56d00e5d00000000000f424000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002d775b4fb1198695e4e6fb37e3a2f25dc5027e3572d6f139b68720bfa56d00e5d000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000040eda6f2a12fe22e5ab5c17d8b4892230d44d0eda381be8ec8435ba584e512b6c06435c2cdf33fb88f7802a6762c08c388115d229208cb902a85ebd18544d13d8f"}}} |
As well as https://github.com/FuelLabs/fuels-ts/actions/runs/8880413928/job/24380375347?pr=2199#step:10:709 post-merge of the first wave of the network release cycle FAIL packages/fuel-gauge/src/transaction-response.test.ts > TransactionResponse > should throw error for a SqueezedOut status update [submitAndAwait]
Error: Passed-in lambda didn't throw.
❯ Module.expectToThrowFuelError packages/errors/src/test-utils/safeExec.ts:101:11
12|
13| return { error, result };
14| };
| ^
15| |
I'm unassigning myself as these seem far less frequent post-upgrade |
https://github.com/FuelLabs/fuels-ts/actions/runs/9108478633/job/25044563729#step:5:699
|
https://github.com/FuelLabs/fuels-ts/actions/runs/9157236096/job/25173194256?pr=2332#step:5:635
|
|
Relates to #2250
|
Another possible flaky:
|
Fixed in #2759cc @nedsalk FAIL packages/account/src/test-utils/launchNode-singular-test.test.ts > launchNode-singular-test > synchronous cleanup kills node before test runner exits
AssertionError: promise resolved "Response{ [Symbol(realm)]: null, …(2) }" instead of rejecting
- Expected
+ Received
- [Error: rejected promise]
+ Response {
+ Symbol(realm): null,
+ Symbol(state): Object {
+ "aborted": false,
+ "body": Object {
+ "stream": ReadableStream {
+ Symbol(kType): "ReadableStream",
+ Symbol(kState): Object {
+ "controller": ReadableStreamDefaultController {
+ Symbol(kType): "ReadableStreamDefaultController",
+ Symbol(kState): Object {
+ "cancelAlgorithm": [Function bound cancel],
+ "closeRequested": false,
+ "highWaterMark": 0,
+ "pullAgain": false,
+ "pullAlgorithm": [Function bound pull],
+ "pulling": false,
+ "queue": Array [],
+ "queueTotalSize": 0,
+ "sizeAlgorithm": [Function size],
+ "started": true,
+ "stream": ReadableStream {
+ Symbol(kType): "ReadableStream",
+ Symbol(kState): [Circular],
+ Symbol(nodejs.webstream.isClosedPromise): Object {
+ "promise": Promise {},
+ "reject": [Function anonymous],
+ "resolve": [Function anonymous],
+ },
+ Symbol(nodejs.webstream.controllerErrorFunction): [Function bound error],
+ },
+ },
+ },
+ "disturbed": false,
+ "reader": undefined,
+ "state": "readable",
+ "storedError": undefined,
+ "stream": undefined,
+ "transfer": Object {
+ "port1": undefined,
+ "port2": undefined,
+ "promise": undefined,
+ "writable": undefined,
+ },
+ },
+ Symbol(nodejs.webstream.isClosedPromise): Object {
+ "promise": Promise {},
+ "reject": [Function anonymous],
+ "resolve": [Function anonymous],
+ },
+ Symbol(nodejs.webstream.controllerErrorFunction): [Function bound error],
+ },
+ },
+ "cacheState": "",
+ "headersList": HeadersList {
+ "cookies": null,
+ Symbol(headers map): Map {
+ "access-control-allow-origin" => Object {
+ "name": "access-control-allow-origin",
+ "value": "*",
+ },
+ "access-control-allow-methods" => Object {
+ "name": "access-control-allow-methods",
+ "value": "*",
+ },
+ "access-control-allow-headers" => Object {
+ "name": "access-control-allow-headers",
+ "value": "*",
+ },
+ "content-length" => Object {
+ "name": "content-length",
+ "value": "0",
+ },
+ "date" => Object {
+ "name": "date",
+ "value": "Fri, 12 Jul 2024 06:25:43 GMT",
+ },
+ },
+ Symbol(headers map sorted): null,
+ },
+ "rangeRequested": false,
+ "requestIncludesCredentials": true,
+ "status": 405,
+ "statusText": "Method Not Allowed",
+ "timingAllowPassed": true,
+ "timingInfo": Object {
+ "decodedBodySize": 0,
+ "encodedBodySize": 0,
+ "endTime": 0,
+ "finalConnectionTimingInfo": null,
+ "finalNetworkRequestStartTime": 0,
+ "finalNetworkResponseStartTime": 0,
+ "finalServiceWorkerStartTime": 0,
+ "postRedirectStartTime": 135863.21586599[998](https://github.com/FuelLabs/fuels-ts/actions/runs/9898356515/job/27358845148?pr=2757#step:5:1012),
+ "redirectEndTime": 0,
+ "redirectStartTime": 0,
+ "startTime": 135863.215865[999](https://github.com/FuelLabs/fuels-ts/actions/runs/9898356515/job/27358845148?pr=2757#step:5:1013)98,
+ },
+ "type": "basic",
+ "urlList": Array [
+ "http://0.0.0.0:4002/v1/graphql",
+ ],
+ },
+ Symbol(headers): Headers {
+ Symbol(guard): "immutable",
+ Symbol(headers list): HeadersList {
+ "cookies": null,
+ Symbol(headers map): Map {
+ "access-control-allow-origin" => Object {
+ "name": "access-control-allow-origin",
+ "value": "*",
+ },
+ "access-control-allow-methods" => Object {
+ "name": "access-control-allow-methods",
+ "value": "*",
+ },
+ "access-control-allow-headers" => Object {
+ "name": "access-control-allow-headers",
+ "value": "*",
+ },
+ "content-length" => Object {
+ "name": "content-length",
+ "value": "0",
+ },
+ "date" => Object {
+ "name": "date",
+ "value": "Fri, 12 Jul 2024 06:25:43 GMT",
+ },
+ },
+ Symbol(headers map sorted): null,
+ },
+ Symbol(realm): null,
+ },
+ } |
This
|
Ditto: |
Closing this before it grows legs and starts chasing us. Seriously tho, it's time for a new flaky season: |
We have a number of flakey tests in CI. The source of which seems to be the shared
fuel-core
node across test suites. Given we have merged #2378 we can now integratelaunchTestNode
across our testing infrastructure, then we review the flakey tests.E.g. I've seen this one a couple of times now:
https://github.com/FuelLabs/fuels-ts/actions/runs/7914766231/job/21605183065#step:9:505
Here's the list of issues related to the integration of
launchTestNode
across our suites:launchTestNode
withfuel-gauge
#1820launchTestNode
into templates #2744launchTestNode
in remaining packages #2698The text was updated successfully, but these errors were encountered: