fix: flaky test tweaking-the-blockchain.test.ts
#1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedsalk
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10 and
danielbate
as code owners
|
Is this related to #1755? I'd say we should employ this strategy of spinning up nodes for when we get to #1356 and, before that, ideally fix the flakiness another way like it was done in the past. Can't remember who did it, maybe @Torres-ssf. |
danielbate
previously approved these changes
Feb 19, 2024
arboleya
previously approved these changes
Feb 19, 2024
arboleya
approved these changes
Feb 19, 2024
Dhaiwat10
approved these changes
Feb 19, 2024
|
Coverage Report:
Changed Files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been failing in multiple CI runs recently. Dhai updated in in this commit but his PR still needs some reviewing and this one can go through faster.