Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object Search with UUID and ID #56

Merged
merged 7 commits into from
Jan 6, 2025

Conversation

Melon-PieldeSapo
Copy link
Collaborator

Fix for actor functions looking up tables and items from compendium to be hable to work with world defined tables and items.

@Melon-PieldeSapo
Copy link
Collaborator Author

Melon-PieldeSapo commented Dec 16, 2024

This branch is ready to merge.
changes:

  • change search loops in compendiums to work with both UUID and ID
  • be hable to retrive world defined items (outside compendiums).
  • centralize search code into mosh.js -> created function fromIdUuid()

@Melon-PieldeSapo Melon-PieldeSapo added this to the 0.5.25 milestone Dec 16, 2024
@Melon-PieldeSapo Melon-PieldeSapo added the enhancement New feature or request label Dec 16, 2024
@Melon-PieldeSapo Melon-PieldeSapo changed the title Actor-get-items-from-world Object Search with UUID and ID Dec 16, 2024
Copy link
Collaborator

@pconcepcion pconcepcion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks much more clear with a separate function to find the things, but I think we can improve naming and/or comments to make it more clear the usage of the new function.

module/mosh.js Outdated Show resolved Hide resolved
module/mosh.js Show resolved Hide resolved
@Melon-PieldeSapo Melon-PieldeSapo merged commit ebeb618 into 0.5.25-release Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants