Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compositional multiphase fluid properties #2542

Merged
merged 19 commits into from
Sep 20, 2023

Conversation

dkachuma
Copy link
Contributor

@dkachuma dkachuma commented Jun 22, 2023

Creates a utility for the calculation of compositional multiphase properties

  • Molar density
  • Mass density

Adds unit tests to compare against values generated by PVTPackage

#2465

@dkachuma dkachuma self-assigned this Jun 22, 2023
@dkachuma dkachuma added the type: feature New feature or request label Jun 22, 2023
@dkachuma dkachuma mentioned this pull request Jun 22, 2023
24 tasks
@dkachuma dkachuma marked this pull request as ready for review June 23, 2023 14:56
@dkachuma dkachuma requested a review from francoishamon June 26, 2023 20:52
@dkachuma dkachuma requested a review from jafranc July 28, 2023 16:59
Copy link
Contributor

@jafranc jafranc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work ! Thanks

@dkachuma dkachuma added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Sep 8, 2023
@TotoGaz TotoGaz merged commit c4052de into develop Sep 20, 2023
@TotoGaz TotoGaz deleted the feature/dkachuma/compositional-properties branch September 20, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants