Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fluid unit tests #2695

Merged
merged 6 commits into from
Oct 28, 2023
Merged

Refactor fluid unit tests #2695

merged 6 commits into from
Oct 28, 2023

Conversation

dkachuma
Copy link
Contributor

#2465

@dkachuma dkachuma mentioned this pull request Sep 21, 2023
Open
24 tasks
@dkachuma dkachuma self-assigned this Sep 22, 2023
@dkachuma dkachuma marked this pull request as ready for review September 22, 2023 15:08
paveltomin
paveltomin approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@paveltomin paveltomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look good, hope you will manage to fix the failing builds

jafranc
jafranc approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@jafranc jafranc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work ! Thank you @dkachuma, it is so easier to read through now

src/coreComponents/constitutive/unitTests/testCompositionalProperties.cpp Outdated Show resolved Hide resolved
@dkachuma dkachuma added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Oct 18, 2023
@rrsettgast rrsettgast merged commit 5d5b86a into develop Oct 28, 2023
@rrsettgast rrsettgast deleted the feature/dkachuma/fluid-unit-test-derivatives branch October 28, 2023 05:38
pradhyumna85 pushed a commit to pradhyumna85/GEOS that referenced this pull request Nov 2, 2023
@dkachuma @pradhyumna85
Refactor fluid unit tests (GEOS-DEV#2695)
752a859
ouassimkh pushed a commit that referenced this pull request Feb 16, 2024
@dkachuma @ouassimkh
Refactor fluid unit tests (#2695)
a08b6b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafranc jafranc jafranc approved these changes

@paveltomin paveltomin paveltomin approved these changes

Assignees

@dkachuma dkachuma

Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review type: cleanup / refactor Non-functional change (NFC)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkachuma @paveltomin @jafranc @rrsettgast