Fixing added model suite questions bug for localensembleda #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dooruk
added a commit
that referenced
this pull request
Mar 20, 2024
* Add new task questions in prep for computing hofx for ensemble members * Define RunJediHofxEnsembleExecutable as an additional Slurm executable w/in Swell * Define ensemble_hofx_strategy/packets to coordinate H(x) computation for ensemble members * Add ensemble_hofx_strategy/packets to original LocalEnsembleDA yaml generation * Shell of future RunJediHofxEnsembleExecutable task * Potential update to localensembleda flow, both running DA and computing member observers * Attempt to set ensemble_hofx_strategy via suite questions * Fixing added model suite questions bug for localensembleda (#291) * Move all ensemble specific task questions to suite questions * Infrastructure for serial/parallel ensemble hofx observers * RunJediHofxEnsembleExecutable inherits from RunJediHofxExecutable; related task question additions * Specify variables as being visible to RunJediHofxEnsembleExecutable * Define fv3-jedi executable associated with ensemblehofx jedi_application * Render all parts of configuration yamls for ensemblehofx jedi_application; nothing too specific yet * Decrease verbosity * Introduce additional swell task option to support ensemble packets * Correct fv3-jedi executable used for ensemblehofx * Standardize names of config yamls for ensemblehofx to agree with hofx * Render ensemblehofx template, and each derived member hofx template * Update localensembleda tier-1 tests * coding norms * swell test fix * commenting out RunJediHofxExecutable import * unused vars * updated task questions * updating task question yamls * debugging action * check if default check works * debug action * uncomment task_question_dicts * removing old keys * make task related changes to output different observation files * ensemble packets are handled as task questions * changes for cylc handling * codestyle fix * cycle time missing in iterator --------- Co-authored-by: Callum Wayman <[email protected]> Co-authored-by: Akira Sewnath <[email protected]> Co-authored-by: asewnath <[email protected]> Co-authored-by: dooruk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows users to add model suite questions.
Dependencies
Impact