Towards ensemble hofx support #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for ensemble members
…ng member observers
…lated task question additions
…tion; nothing too specific yet
|
I think you are requesting for too many reviewers for this. It delays things too much. |
rtodling
approved these changes
Mar 19, 2024
danholdaway
added a commit
to danholdaway/swell
that referenced
this pull request
Apr 19, 2024
* develop: Resolve pandas warnings (GEOS-ESM#322) Add atmospheric 3DVar case (GEOS-ESM#302) Update to Skylab7 Modules - Part 1 (SLES12) (GEOS-ESM#319) Towards ensemble hofx support (GEOS-ESM#298) Change Jedi Log plot and turn off Jb evaluation (GEOS-ESM#310) passed benchmark change (GEOS-ESM#303) Use `EXPLICIT_DIFFUSION` as Static Background for `geos_marine` (GEOS-ESM#301) Fix to check for missing obs in SaveObsDiag (GEOS-ESM#299) Cloning GEOS_mksi instead for GSI channel records (GEOS-ESM#297) Update modules and keep static files in shared locations (GEOS-ESM#296) Addressing missing observations (GEOS-ESM#286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends the
localensembledasuite by separating the ensemble H(x) computation from the analysis step. Introduced structures to compute ensemble observers in either a serial or parallel workflow.-p) has been added toswell taskthat should be triggered when ensemble workflows are run. This new option specifies to an ensemble-related task which "packet" of ensemble members it should handle. Together with additional suite/task questions, ensemble-related tasks can operate on mutually exclusive subsets of ensemble members.Impact
RunJediHofxExecutableclass inrun_jedi_hofx_executable.pyto produce hofx yamls for each ensemble member; minor rearrangement of said script as well.@Dooruk edit:
@asewnath and I had to make some additional changes to make sure
hofx_executablewasn't impacted.I confined the ensemble_packet related entries to
task_questions, which worked fine but we should see how do they work with the questionnaire.There still needs to be another task to combine individual h(x)_* outputs as LETKF executable requires observations to be in the same IODA file with the hofx0** naming convention.
Thanks @CEgerer93 for working on this and for your changes.