Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional db transform logic #123

Merged
merged 2 commits into from
Jan 7, 2025
Merged

add additional db transform logic #123

merged 2 commits into from
Jan 7, 2025

Conversation

rshewitt
Copy link
Contributor

@rshewitt rshewitt commented Jan 6, 2025

  • lint (i ended up keeping this because it's a result of running our make lint command)
  • add log for successful transformation
  • update invalid transform test to check db error message and record status
  • update valid transform test so the "transform" function has access to the db record id. i can change this but it seemed informative to include the db record guuid in the log.

Pull Request

Related to #4759

About

PR TASKS

  • The actual code changes.
  • Tests written and passed.
  • Any changes to docs?

@rshewitt rshewitt requested a review from a team January 6, 2025 20:56
@rshewitt rshewitt force-pushed the update-db-transform branch from 76dcae5 to c6e881f Compare January 6, 2025 21:00
@rshewitt rshewitt marked this pull request as draft January 6, 2025 23:46
@rshewitt rshewitt force-pushed the update-db-transform branch from c6e881f to 750bc0e Compare January 7, 2025 17:34
@rshewitt rshewitt marked this pull request as ready for review January 7, 2025 17:39
@rshewitt rshewitt merged commit 9252373 into main Jan 7, 2025
4 checks passed
@rshewitt rshewitt deleted the update-db-transform branch January 7, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants