SRCH-1754 update Elasticsearch initializer & client #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing temporarily to make a tweak. |
jmax315
reviewed
Dec 2, 2020
| end | ||
|
|
||
| Elasticsearch::Persistence.client = ES.client |
There was a problem hiding this comment.
Why is the assignment to Elasticsearch::Persistence.client necessary? Backwards compatibility for some code that this PR doesn't change?
There was a problem hiding this comment.
Yes, that's for backwards compatibility. It sets the client for the persisted classes (Document and Collection), replicating the logic of the existing client assignment, but using the new ES.client method. That line is going to go away in a subsequent commit.
jmax315
approved these changes
Dec 2, 2020
jmax-fearless
approved these changes
Dec 2, 2020
MothOnMars
added a commit
that referenced
this pull request
Feb 25, 2021
…rch 7 (#131) * SRCH-1754 update Elasticsearch initializer & client (#128) * SRCH-1743 create repository classes (#130) * SRCH-1755 upgrade elasticsearch gems to 6.x (#134) * SRCH-1819 return total search hits as an integer (#138) * SRCH-1818 set minimum_should_match to 1 in bool filter (#139) * SRCH-1730 update templates (#137) * SRCH-1820 add Elasticsearch & Kibana 7 to docker-compose.yml (#136) * SRCH-1718 run specs against Elasticsearch 6 & 7 (#140) * SRCH-1876 fix intermittent spec failures (#141) - replace patron with typhoeus - bump nokogiri * SRCH-1854 set ID when deserializing (#142) * SRCH-1822 placate Rubocop (#143)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of several PRs into the
release/elasticsearch_gems_1727branch. I've broken up the changes largely to simplify the review process. This PR updates the Elasticsearch client initializer to avoid using theElasticsearch::Persistence.clientmethod, which is deprecated in the next version of theelasticsearch-persistencegem. That will still be in temporary use to set the persistence client (Elasticsearch::Persistence.client = ES.client) until I update the gems.It also adds a couple of test helpers to DRY up the specs.