SRCH-1743 create repository classes #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmax-fearless
approved these changes
Dec 3, 2020
MothOnMars
added a commit
that referenced
this pull request
Feb 25, 2021
…rch 7 (#131) * SRCH-1754 update Elasticsearch initializer & client (#128) * SRCH-1743 create repository classes (#130) * SRCH-1755 upgrade elasticsearch gems to 6.x (#134) * SRCH-1819 return total search hits as an integer (#138) * SRCH-1818 set minimum_should_match to 1 in bool filter (#139) * SRCH-1730 update templates (#137) * SRCH-1820 add Elasticsearch & Kibana 7 to docker-compose.yml (#136) * SRCH-1718 run specs against Elasticsearch 6 & 7 (#140) * SRCH-1876 fix intermittent spec failures (#141) - replace patron with typhoeus - bump nokogiri * SRCH-1854 set ID when deserializing (#142) * SRCH-1822 placate Rubocop (#143)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up the new Repository classes, which will subsequently be used to store the corresponding
DocumentandCollectioninstances. The goal is to decouple the model logic from the persistence logic. A detailed explanation of why and how these changes are being made is in:https://www.elastic.co/blog/activerecord-to-repository-changing-persistence-patterns-with-the-elasticsearch-rails-gem
The follow-up commits will build on these repository classes, moving the persistence, serialization, and search logic out of the
DocumentandCollectionclasses and into the repository classes. (I toyed with retaining theelasticsearch-modelgem, which offers ActiveRecord-y persistence to POROs, but ultimately I agree w/ the recommendation to decouple the model/ persistence logic. It won't surprise me at all if theelasticsearch-modelgem is deprecated in the future, which also makes this a safer route.)