refactor: improve update category responses♻️

src/modules/categories/category.handlers.ts

@@ -19,7 +19,7 @@ import {
   getAllCategoriesUserRepository,
   getCategoryByIdOrNameRepository,
   getCategoryRepository,
-  updateCategoryByIdAndUserIdRepository,
+  updateCategoryByIdRepository,
 } from "./category.repository";
 
 export const createCategory: AppRouteHandler<TCreateCategoryRoute> = async (
@@ -184,37 +184,56 @@ export const updateCategory: AppRouteHandler<TUpdateCategoryRoute> = async (
   const { categoryId } = c.req.valid("param");
   const payload = c.req.valid("json");
 
-  let category: TSelectCategorySchema | null = null;
+  const category = await getCategoryRepository(categoryId);
 
-  if (user?.role !== AuthRoles.ADMIN) {
-    logger.debug("Non admin user can only update their own categories");
+  if (!category) {
+    logger.error(`Category with id ${categoryId} not found`);
+    return c.json(
+      {
+        success: false,
+        message: "Category not found",
+      },
+      HTTPStatusCodes.NOT_FOUND,
+    );
+  }
 
-    category = await updateCategoryByIdAndUserIdRepository(
-      categoryId,
-      payload,
-      user?.id,
+  if (user?.role !== AuthRoles.ADMIN && category.userId !== user?.id) {
+    logger.error(
+      `User ${user?.id} not authorized to update category ${categoryId}`,
+    );
+    return c.json(
+      {
+        success: false,
+        message: "You are not authorized to update this category",
+      },
+      HTTPStatusCodes.FORBIDDEN,
     );
-  } else if (user?.role === AuthRoles.ADMIN) {
-    category = await updateCategoryByIdAndUserIdRepository(categoryId, payload);
   }
 
-  if (!category) {
+  const updatedCategory = await updateCategoryByIdRepository(
+    categoryId,
+    payload,
+  );
+
+  if (!updatedCategory) {
     logger.error("Failed to update category");
     return c.json(
       {
         success: false,
-        message: "Invalid category id or you are not allowed to update",
+        message: "Failed to update category",
       },
-      HTTPStatusCodes.NOT_FOUND,
+      HTTPStatusCodes.INTERNAL_SERVER_ERROR,
     );
   }
 
-  logger.info(`Category updated successfully with name ${category.name}`);
+  logger.info(
+    `Category updated successfully with name ${updatedCategory.name}`,
+  );
   return c.json(
     {
       success: true,
       message: "Category updated successfully",
-      data: category,
+      data: updatedCategory,
     },
     HTTPStatusCodes.OK,
   );

src/modules/categories/category.repository.ts

@@ -193,17 +193,12 @@ export async function getCategoryByIdOrNameRepository(
   return category;
 }
 
-export async function updateCategoryByIdAndUserIdRepository(
+export async function updateCategoryByIdRepository(
   categoryId: string,
   categoryPayload: Partial<TInsertCategorySchema>,
-  userId?: string,
 ) {
   const whereCondition = [eq(categoryModel.id, categoryId)];
 
-  if (userId) {
-    whereCondition.push(eq(categoryModel.userId, userId));
-  }
-
   categoryPayload.name = categoryPayload?.name?.toLowerCase();
   categoryPayload.updatedAt = new Date();
 

src/modules/categories/category.routes.ts

@@ -192,6 +192,13 @@ export const updateCategoryRoute = createRoute({
       }),
       "You are not allowed to perform this action",
     ),
+    [HTTPStatusCodes.INTERNAL_SERVER_ERROR]: jsonContent(
+      z.object({
+        success: z.boolean().default(false),
+        message: z.string(),
+      }),
+      "Failed to update category",
+    ),
   },
 });