-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add summary to group endpoints for openapi docs📝 #105
docs: add summary to group endpoints for openapi docs📝 #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/modules/group/group.handler.ts:342
- [nitpick] The error message 'Some or all the Users you are trying to add already exists in group' is unclear. Consider rephrasing it to 'Some or all of the users you are trying to add already exist in the group'.
message: "Some or all the Users you are trying to add already exists in group",
src/modules/group/group.handler.ts:327
- Ensure that the new behavior introduced by 'usersExistsInGroupRepository' is covered by tests.
const usersExistsInGroup = await usersExistsInGroupRepository(
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/modules/group/group.handler.ts:332
- The condition should check if
usersExistsInGroup
is not empty to handle cases where the array is undefined or null. Useif (usersExistsInGroup && usersExistsInGroup.length) {
.
if (usersExistsInGroup.length) {
src/modules/group/group.handler.ts:333
- [nitpick] The variable
existingUserIds
should be renamed toexistingUserIdsInGroup
for better clarity and consistency with the function name.
const existingUserIds = usersExistsInGroup.map(user => user.userId);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shivamvijaywargi @NiteshSoma after seeing this PR, i have one doubt - Do we have a route which will return users of a particular group, because in frontend users adding screen, we have to hide users which are already part of that group so this validatation will not fail. If possible we can return users details in GET /api/v1/group/:id
itself.
@sub1120 I am actually working on that issue where we get back user details in getGroupById |
Ooh nice.
Oh Nice! Then we are good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
No description provided.