Feature/8 crud group table #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
package.json
Outdated
| @@ -26,6 +26,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@hono/zod-openapi": "^0.17.0", | |||
| "@node-rs/argon2": "^2.0.0", | |||
There was a problem hiding this comment.
This dependency is no more required and was removed in a previous MR, please take the latest pull from main.
src/modules/group/group.handler.ts
Outdated
| } | ||
|
|
||
| let group: TSelectGroupSchema | null = null; | ||
| group = await createGroupRepository(payload); |
There was a problem hiding this comment.
You could directly do const group = await createGroupRepository(payload);
src/modules/group/group.handler.ts
Outdated
| } | ||
|
|
||
| let deletedGroupId: string | null = null; | ||
| deletedGroupId = await deleteGroupRepository(params.id); |
There was a problem hiding this comment.
Same previous comment applies.
shivamvijaywargi
requested changes
Nov 15, 2024
shivamvijaywargi
requested changes
Nov 15, 2024
src/modules/group/group.handler.ts
Outdated
| const group: TSelectGroupSchema | null = await createGroupRepository(payload); | ||
|
|
||
| if (!group) { | ||
| logger.debug("Failed to create group"); |
There was a problem hiding this comment.
This should be an error log, logger.error()
added 2 commits
November 15, 2024 19:18
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.