Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: activity for add users to group♻️ #98

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

shivamvijaywargi
Copy link
Contributor

@shivamvijaywargi shivamvijaywargi commented Dec 9, 2024

This pull request includes changes to the src/modules/activities/activity.utils.ts file to enhance the organization and formatting of activity data. The most important changes include the addition of new activity types and the corresponding formatting functions.

Example format:
CleanShot 2024-12-09 at 21 32 48@2x

@shivamvijaywargi shivamvijaywargi added the refactor Make code more better, readable, maintainable label Dec 9, 2024
@shivamvijaywargi shivamvijaywargi added this to the V1.0 milestone Dec 9, 2024
@shivamvijaywargi shivamvijaywargi self-assigned this Dec 9, 2024
@Copilot Copilot bot review requested due to automatic review settings December 9, 2024 15:56
@github-actions github-actions bot added the bug Something isn't working label Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (2)

src/modules/activities/activity.utils.ts:68

  • The error message 'Unknown category activityMetadata' is unclear. Consider changing it to 'Unknown category activity'.
return { id: '', message: 'Unknown category activityMetadata' };

src/modules/activities/activity.utils.ts:102

  • The error message 'Unknown group activityMetadata' is unclear. Consider changing it to 'Unknown group activity'.
return { id: '', message: 'Unknown group activityMetadata' };
@github-actions github-actions bot added enhancement New feature or request release labels Dec 9, 2024
Copy link

sonarqubecloud bot commented Dec 9, 2024

@shivamvijaywargi shivamvijaywargi merged commit 511fe9a into main Dec 10, 2024
7 checks passed
@shivamvijaywargi shivamvijaywargi deleted the refactor/users-to-group-activity-log branch December 10, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request refactor Make code more better, readable, maintainable release
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant