Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #5463] Change geolite2-city endpoint #5472

Merged
merged 1 commit into from
Jan 7, 2020
Merged

[Fixes #5463] Change geolite2-city endpoint #5472

merged 1 commit into from
Jan 7, 2020

Conversation

afabiani
Copy link
Member

@afabiani afabiani commented Jan 7, 2020

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there are explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@afabiani afabiani added this to the 2.10.2 milestone Jan 7, 2020
@afabiani afabiani requested a review from t-book January 7, 2020 12:17
@afabiani afabiani self-assigned this Jan 7, 2020
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 7, 2020
Copy link
Contributor

@t-book t-book left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afabiani The only thing I would mention is that sharing of your token could be a security risk. But in case this is fine for you all I can say is:

thanks a lot! 👍

@afabiani afabiani merged commit 3c749f0 into master Jan 7, 2020
@afabiani afabiani deleted the ISSUE_5463 branch January 7, 2020 13:51
afabiani pushed a commit that referenced this pull request Jan 7, 2020
[Fixes #5463] Change geolite2-city endpoint

(cherry picked from commit 3c749f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants