This repository has been archived by the owner on Dec 31, 2024. It is now read-only.
Should not be able to delegate/donate more the the maxAmount to a milestone
#386
Assignees
Comments
vojtechsimetka
added a commit
that referenced
this issue
Aug 4, 2018
* develop: (29 commits) Removed the prefilled recipient address. This might be prefilled as a metamask address but should not stay DApp address. Fixes #386 This whole thing should be rewritten but for the time being it is unlikely that some milestones will be hidden in the delegate button (the service returns latest 100 that are in progress and has not been fully funded yet). Fixes #401 Fixes #442 closes #383 update web3 version Fixed type error remove item.etherAmount simplify profile view, only show mileste users, not addys fix DonateButton bug if user cancels tx Add check for wallet balance in refund Remove text confirmation while cancelling milestone Add package-lock rm package-lock.json Refactor Actually fixing #446... Fixes #448 Improve delete milestone confirmation Improve refund donation confirmation Improve cancel milestone confirmation ...
vojtechsimetka
added a commit
that referenced
this issue
Aug 5, 2018
* develop: (25 commits) Removed the prefilled recipient address. This might be prefilled as a metamask address but should not stay DApp address. Fixes #386 This whole thing should be rewritten but for the time being it is unlikely that some milestones will be hidden in the delegate button (the service returns latest 100 that are in progress and has not been fully funded yet). Fixes #401 Fixes #442 closes #383 update web3 version Fixed type error remove item.etherAmount simplify profile view, only show mileste users, not addys fix DonateButton bug if user cancels tx Add check for wallet balance in refund Remove text confirmation while cancelling milestone Add package-lock rm package-lock.json Refactor Actually fixing #446... Fixes #448 Improve delete milestone confirmation Improve refund donation confirmation Improve cancel milestone confirmation ... # Conflicts: # src/components/views/MyCampaigns.jsx
vojtechsimetka
added a commit
that referenced
this issue
Aug 6, 2018
* release: (33 commits) Allows unregistered users to donate (but displays warning). Fixing GA linter issues. Removed the prefilled recipient address. This might be prefilled as a metamask address but should not stay DApp address. tracking events and pageviews tracking events and pageviews Fixes #386 This whole thing should be rewritten but for the time being it is unlikely that some milestones will be hidden in the delegate button (the service returns latest 100 that are in progress and has not been fully funded yet). Fixes #401 Fixes #442 closes #383 update web3 version Fixed type error remove item.etherAmount simplify profile view, only show mileste users, not addys fix DonateButton bug if user cancels tx Add check for wallet balance in refund Remove text confirmation while cancelling milestone Add package-lock rm package-lock.json Refactor Actually fixing #446... ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In the ui, I can currently delegate more then the
maxAmountof a milestone. The excess is returned to me on the contract side of things, but this is a bit confusing.I'm not sure about the current donate behavior, but it should be the same as above
The text was updated successfully, but these errors were encountered: