Skip to content
This repository has been archived by the owner on Jan 25, 2025. It is now read-only.

Commit

Permalink
feat: upgrade to stylelint 16 and migrate to stylelint-codeguide
Browse files Browse the repository at this point in the history 
As per elirasza/stylelint-stylistic#17 (comment)
  • Loading branch information
@EvHaus
EvHaus committed Dec 17, 2023
1 parent c2098e0 commit 9fd3ee9
Show file tree
Hide file tree
Showing 3 changed files with 243 additions and 268 deletions.
156 changes: 78 additions & 78 deletions index.js
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module.exports = {
plugins: [
'stylelint-codeguide',
'stylelint-order',
'stylelint-stylistic',
],
rules: {
// ERRORS
Expand All @@ -14,6 +14,72 @@ module.exports = {
'at-rule-no-unknown': true,
'at-rule-no-vendor-prefix': true,
'block-no-empty': true,
'codeguide/at-rule-name-case': 'lower',
'codeguide/at-rule-name-space-after': 'always',
'codeguide/at-rule-semicolon-newline-after': 'always',
'codeguide/at-rule-semicolon-space-before': 'never',
'codeguide/block-closing-brace-empty-line-before': 'never',
'codeguide/block-closing-brace-newline-after': 'always',
'codeguide/block-closing-brace-space-before': 'always-single-line',
'codeguide/block-opening-brace-newline-after': 'always-multi-line',
'codeguide/block-opening-brace-space-after': 'always-single-line',
'codeguide/block-opening-brace-space-before': 'always-multi-line',
'codeguide/color-hex-case': 'upper',
'codeguide/declaration-bang-space-after': 'never',
'codeguide/declaration-bang-space-before': 'always',
'codeguide/declaration-block-semicolon-newline-after': 'always-multi-line',
'codeguide/declaration-block-semicolon-newline-before': 'never-multi-line',
'codeguide/declaration-block-semicolon-space-after': 'always-single-line',
'codeguide/declaration-block-semicolon-space-before': 'never-single-line',
'codeguide/declaration-colon-newline-after': 'always-multi-line',
'codeguide/declaration-colon-space-after': 'always-single-line',
'codeguide/declaration-colon-space-before': 'never',
'codeguide/function-comma-newline-after': 'always-multi-line',
'codeguide/function-comma-newline-before': 'never-multi-line',
'codeguide/function-comma-space-after': 'always-single-line',
'codeguide/function-comma-space-before': 'never',
'codeguide/function-max-empty-lines': 2,
'codeguide/function-parentheses-newline-inside': 'always-multi-line',
'codeguide/function-parentheses-space-inside': 'never-single-line',
'codeguide/function-whitespace-after': 'always',
'codeguide/indentation': 'tab',
'codeguide/max-empty-lines': 2,
'codeguide/max-line-length': 120,
'codeguide/media-feature-colon-space-after': 'always',
'codeguide/media-feature-colon-space-before': 'never',
'codeguide/media-feature-name-case': 'lower',
'codeguide/media-feature-parentheses-space-inside': 'never',
'codeguide/media-feature-range-operator-space-after': 'always',
'codeguide/media-feature-range-operator-space-before': 'always',
'codeguide/media-query-list-comma-newline-after': 'always-multi-line',
'codeguide/media-query-list-comma-newline-before': 'never-multi-line',
'codeguide/media-query-list-comma-space-after': 'always-single-line',
'codeguide/media-query-list-comma-space-before': 'never',
'codeguide/no-extra-semicolons': true,
'codeguide/number-leading-zero': 'always',
'codeguide/number-no-trailing-zeros': true,
'codeguide/property-case': 'lower',
'codeguide/selector-attribute-brackets-space-inside': 'never',
'codeguide/selector-attribute-operator-space-after': 'never',
'codeguide/selector-attribute-operator-space-before': 'never',
'codeguide/selector-combinator-space-after': 'always',
'codeguide/selector-combinator-space-before': 'always',
'codeguide/selector-descendant-combinator-no-non-space': true,
'codeguide/selector-list-comma-newline-after': 'always-multi-line',
'codeguide/selector-list-comma-newline-before': 'never-multi-line',
'codeguide/selector-list-comma-space-after': 'always-single-line',
'codeguide/selector-list-comma-space-before': 'never',
'codeguide/selector-max-empty-lines': 0,
'codeguide/selector-pseudo-class-case': 'lower',
'codeguide/selector-pseudo-class-parentheses-space-inside': 'never',
'codeguide/selector-pseudo-element-case': 'lower',
'codeguide/string-quotes': 'double',
'codeguide/unit-case': 'lower',
'codeguide/value-list-comma-newline-after': 'always-multi-line',
'codeguide/value-list-comma-newline-before': 'never-multi-line',
'codeguide/value-list-comma-space-after': 'always-single-line',
'codeguide/value-list-comma-space-before': 'never',
'codeguide/value-list-max-empty-lines': 0,
'color-function-notation': 'legacy',
'color-hex-alpha': 'never',
'color-hex-length': 'short',
Expand Down Expand Up @@ -97,72 +163,6 @@ module.exports = {
'selector-type-no-unknown': true,
'shorthand-property-no-redundant-values': true,
'string-no-newline': true,
'stylistic/at-rule-name-case': 'lower',
'stylistic/at-rule-name-space-after': 'always',
'stylistic/at-rule-semicolon-newline-after': 'always',
'stylistic/at-rule-semicolon-space-before': 'never',
'stylistic/block-closing-brace-empty-line-before': 'never',
'stylistic/block-closing-brace-newline-after': 'always',
'stylistic/block-closing-brace-space-before': 'always-single-line',
'stylistic/block-opening-brace-newline-after': 'always-multi-line',
'stylistic/block-opening-brace-space-after': 'always-single-line',
'stylistic/block-opening-brace-space-before': 'always-multi-line',
'stylistic/color-hex-case': 'upper',
'stylistic/declaration-bang-space-after': 'never',
'stylistic/declaration-bang-space-before': 'always',
'stylistic/declaration-block-semicolon-newline-after': 'always-multi-line',
'stylistic/declaration-block-semicolon-newline-before': 'never-multi-line',
'stylistic/declaration-block-semicolon-space-after': 'always-single-line',
'stylistic/declaration-block-semicolon-space-before': 'never-single-line',
'stylistic/declaration-colon-newline-after': 'always-multi-line',
'stylistic/declaration-colon-space-after': 'always-single-line',
'stylistic/declaration-colon-space-before': 'never',
'stylistic/function-comma-newline-after': 'always-multi-line',
'stylistic/function-comma-newline-before': 'never-multi-line',
'stylistic/function-comma-space-after': 'always-single-line',
'stylistic/function-comma-space-before': 'never',
'stylistic/function-max-empty-lines': 2,
'stylistic/function-parentheses-newline-inside': 'always-multi-line',
'stylistic/function-parentheses-space-inside': 'never-single-line',
'stylistic/function-whitespace-after': 'always',
'stylistic/indentation': 'tab',
'stylistic/max-empty-lines': 2,
'stylistic/max-line-length': 120,
'stylistic/media-feature-colon-space-after': 'always',
'stylistic/media-feature-colon-space-before': 'never',
'stylistic/media-feature-name-case': 'lower',
'stylistic/media-feature-parentheses-space-inside': 'never',
'stylistic/media-feature-range-operator-space-after': 'always',
'stylistic/media-feature-range-operator-space-before': 'always',
'stylistic/media-query-list-comma-newline-after': 'always-multi-line',
'stylistic/media-query-list-comma-newline-before': 'never-multi-line',
'stylistic/media-query-list-comma-space-after': 'always-single-line',
'stylistic/media-query-list-comma-space-before': 'never',
'stylistic/no-extra-semicolons': true,
'stylistic/number-leading-zero': 'always',
'stylistic/number-no-trailing-zeros': true,
'stylistic/property-case': 'lower',
'stylistic/selector-attribute-brackets-space-inside': 'never',
'stylistic/selector-attribute-operator-space-after': 'never',
'stylistic/selector-attribute-operator-space-before': 'never',
'stylistic/selector-combinator-space-after': 'always',
'stylistic/selector-combinator-space-before': 'always',
'stylistic/selector-descendant-combinator-no-non-space': true,
'stylistic/selector-list-comma-newline-after': 'always-multi-line',
'stylistic/selector-list-comma-newline-before': 'never-multi-line',
'stylistic/selector-list-comma-space-after': 'always-single-line',
'stylistic/selector-list-comma-space-before': 'never',
'stylistic/selector-max-empty-lines': 0,
'stylistic/selector-pseudo-class-case': 'lower',
'stylistic/selector-pseudo-class-parentheses-space-inside': 'never',
'stylistic/selector-pseudo-element-case': 'lower',
'stylistic/string-quotes': 'double',
'stylistic/unit-case': 'lower',
'stylistic/value-list-comma-newline-after': 'always-multi-line',
'stylistic/value-list-comma-newline-before': 'never-multi-line',
'stylistic/value-list-comma-space-after': 'always-single-line',
'stylistic/value-list-comma-space-before': 'never',
'stylistic/value-list-max-empty-lines': 0,
'time-min-milliseconds': 100,
'unit-disallowed-list': ['em'],
'unit-no-unknown': true,
Expand All @@ -184,6 +184,17 @@ module.exports = {
'at-rule-allowed-list': null,
'at-rule-disallowed-list': null,
'at-rule-property-required-list': null,
'codeguide/at-rule-name-newline-after': null,
'codeguide/block-closing-brace-newline-before': null,
'codeguide/block-closing-brace-space-after': null,
'codeguide/block-opening-brace-newline-before': null,
'codeguide/declaration-block-trailing-semicolon': null,
'codeguide/linebreaks': null,
'codeguide/no-empty-first-line': null,
'codeguide/no-eol-whitespace': null,
'codeguide/no-missing-end-of-source-newline': null,
// This rule seems broken
'codeguide/unicode-bom': 'never',
'comment-empty-line-before': null,
// This rule cannot be turned off with 'null'
// 'comment-pattern': null,
Expand Down Expand Up @@ -224,17 +235,6 @@ module.exports = {
'selector-pseudo-class-disallowed-list': null,
'selector-pseudo-element-allowed-list': null,
'selector-pseudo-element-disallowed-list': null,
'stylistic/at-rule-name-newline-after': null,
'stylistic/block-closing-brace-newline-before': null,
'stylistic/block-closing-brace-space-after': null,
'stylistic/block-opening-brace-newline-before': null,
'stylistic/declaration-block-trailing-semicolon': null,
'stylistic/linebreaks': null,
'stylistic/no-empty-first-line': null,
'stylistic/no-eol-whitespace': null,
'stylistic/no-missing-end-of-source-newline': null,
// This rule seems broken
'stylistic/unicode-bom': 'never',
'unit-allowed-list': null,
},
};
11 changes: 5 additions & 6 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@
"chalk": "4.1.2"
},
"dependencies": {
"stylelint": "15.11.0",
"stylelint-order": "^6.0.4",
"stylelint-stylistic": "^0.4.3"
"stylelint": "16.0.2",
"stylelint-codeguide": "1.0.2",
"stylelint-order": "6.0.4"
},
"devDependencies": {
"@commitlint/cli": "18.4.3",
Expand All @@ -42,11 +42,10 @@
},
"comments": {
"dependencies": {
"stylelint": "Not using ^ versions here to ensure the correct version is always installed as some projects may have a different version installed via some other third-party dependency."
"stylelint-*": "Not using ^ versions here to ensure the correct version is always installed as some projects may have a different version installed via some other third-party dependency."
},
"resolutions": {
"chalk": "Need to lock this to ensure semantic-release works. See https://github.com/semantic-release/semantic-release/issues/2323 for more info",
"stylelint": "Can't upgrade to stylelint 16 until https://github.com/elirasza/stylelint-stylistic/issues/17 is merged"
"chalk": "Need to lock this to ensure semantic-release works. See https://github.com/semantic-release/semantic-release/issues/2323 for more info"
}
}
}
Loading

0 comments on commit 9fd3ee9

Please sign in to comment.