Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to stylelint 16 bro #17

Open
ghost opened this issue Nov 23, 2023 · 7 comments
Open

add support to stylelint 16 bro #17

ghost opened this issue Nov 23, 2023 · 7 comments

Comments

@ghost
Copy link

ghost commented Nov 23, 2023

Please support stylelint 16.0.0, the big one

Now the code is in ESM instead of CommonJS

Very good

Stylelint team published docs to know how to migrate with ease.

No need to keep support to commons from now on.

Style lint 16 is not allowed in your package.json. remove this restriction to

@silverwind
Copy link

It's not compatible with v16 because it apparently still has some imports from stylelint left which changed in v16:

Error: Cannot find module 'node_modules/stylelint/lib/utils/isStandardSyntaxAtRule'
    at createEsmNotFoundErr (node:internal/modules/cjs/loader:1181:15)
    at finalizeEsmResolution (node:internal/modules/cjs/loader:1169:15)
    at resolveExports (node:internal/modules/cjs/loader:591:14)
    at Module._findPath (node:internal/modules/cjs/loader:668:31)
    at Module._resolveFilename (node:internal/modules/cjs/loader:1130:27)
    at Module._load (node:internal/modules/cjs/loader:985:27)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at require (node:internal/modules/helpers:176:18)
    at Object.<anonymous> (node_modules/stylelint-stylistic/dist/rules/at-rule-name-case/index.js:3:32)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)

@tagliala
Copy link

Hi,

I've tried to start working on this, but there are several changes involved, as per https://stylelint.io/migration-guide/to-16/ and at the moment I cannot allocate the time needed

@daniluk4000
Copy link

@elirasza will you have time to work on this or should community take the lead for this one?

@elirasza
Copy link
Owner

elirasza commented Dec 14, 2023

I think the community should take the lead. I have very few time lately, but I suggest you look into https://github.com/firefoxic/stylelint-codeguide. @firefoxic has contacted me, wants to unify both packages, and has already prepared his for stylelint 16 + ESM. I am thinking about deprecating stylelint-stylistic in favor of stylelint-codeguide.

tagliala added a commit to tagliala/stylelint-config-twbs-bootstrap that referenced this issue Dec 14, 2023
Move to stylelint-codeguide to allow the usage of stylelint 16

Ref: elirasza/stylelint-stylistic#17

Close twbs#232
tagliala added a commit to tagliala/stylelint-config-twbs-bootstrap that referenced this issue Dec 14, 2023
Move to stylelint-codeguide to allow the usage of stylelint 16

Ref: elirasza/stylelint-stylistic#17

Close twbs#232
tagliala added a commit to tagliala/stylelint-config-twbs-bootstrap that referenced this issue Dec 14, 2023
Move to stylelint-codeguide to allow the usage of stylelint 16

Ref: elirasza/stylelint-stylistic#17

Close twbs#232
tagliala added a commit to tagliala/stylelint-config-twbs-bootstrap that referenced this issue Dec 14, 2023
Replace stylelint-stylistic with stylelint-codeguide to allow the
usage of Stylelint 16

Also drops Node < 18.12.0 compatibility to match Stylelint requirement

Ref: elirasza/stylelint-stylistic#17

Close twbs#232
tagliala added a commit to tagliala/stylelint-config-twbs-bootstrap that referenced this issue Dec 14, 2023
Replace stylelint-stylistic with stylelint-codeguide to allow the
usage of Stylelint 16

Also drops Node < 18.12.0 compatibility to match
`stylelint-codeguide` requirements

Ref: elirasza/stylelint-stylistic#17

Close twbs#232
tagliala added a commit to tagliala/stylelint-config-twbs-bootstrap that referenced this issue Dec 15, 2023
Replace `stylelint-stylistic` with `stylelint-codeguide` to allow
upgrade to Stylelint 16

Also changes Node version constraints to match `stylelint-codeguide`
requirements

Ref:
- elirasza/stylelint-stylistic#17
- https://github.com/firefoxic/stylelint-codeguide


Close twbs#232, close twbs#206
EvHaus added a commit to GlobexDesignsInc/stylelint-config-globex that referenced this issue Dec 17, 2023
EvHaus added a commit to GlobexDesignsInc/stylelint-config-globex that referenced this issue Dec 17, 2023
EvHaus added a commit to GlobexDesignsInc/stylelint-config-globex that referenced this issue Dec 17, 2023
EvHaus added a commit to GlobexDesignsInc/stylelint-config-globex that referenced this issue Dec 17, 2023
tagliala added a commit to tagliala/stylelint-config-twbs-bootstrap that referenced this issue Dec 19, 2023
Replace `stylelint-stylistic` with `@stylistic/stylelint-plugin` to allow
upgrade to Stylelint 16

Also changes Node version constraints to match new minimum requirements

Ref:
- elirasza/stylelint-stylistic#17
- https://github.com/stylelint-stylistic/stylelint-stylistic

Close twbs#232, close twbs#206
@Mouvedia
Copy link

Mouvedia commented Dec 20, 2023

@firefoxic has contacted me, wants to unify both packages…

This would be great.

@firefoxic
Copy link

This would be great.

Already! https://www.npmjs.com/package/@stylistic/stylelint-plugin 🚀

@Mouvedia
Copy link

@firefoxic that's cool. Ill switch once stylelint-stylistic/stylelint-stylistic#9 is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants