Merge into master #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add force commit button * bugfix * remove temp * added a couple unit tests * consistency * clarity
* Enable erroneously skipped range tests Tox has not been running range_test.py due to the file being executable. This commit sets the file permissions to read/write only and remediates the problems that arose when the tests ran again: * Some tests for RangeMonthly were not accurately capturing the correct logic * Some tests were not compatible with Python 3 in some map operations * RangeByMinutesBase performed arithmetics that yield different results on Python 2 and 3, this was changed to be more resilient on both. May have impact on those relying on the erroneous behavior right now. * Enable erroneously skipped SGE tests Tox has not been running contrib/sge_test.py due to the file being executable. This commit sets the file permissions to read/write only and remediates the problems that arose when the tests ran again: * pickle.dump() behaves differently in Python 2 and 3, ensure that it works for both * Get rid of warnings about unclosed files, handling file lifecycles properly * Minor docstring syntax
…hdfs (#2762) * Replace reference to outdated test environment py27-nonhdfs.
* Add blog post from xtream Add reference to a new Medium post by xtream * Update README to prevent warnings * Update README Prevent warnings also on xtream name
* contrib/ftp: Clean up temporary files * contrib/ftp: generate temporary filenames once * contrib/ftp: slightly cleaner temporary directory names * contrib/ftp: add testcase for tempfile cleanup Also let test work in Python 3. Also make the mtime offset larger because it fails in my timezone.
* Show task history link in visualizer when recording. * Fix test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Have you tested this? If so, how?