Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme quick start use the new actions/setup-node@v2 #520

Closed
wants to merge 1 commit into from
Closed

readme quick start use the new actions/setup-node@v2 #520

wants to merge 1 commit into from

Conversation

janosh
Copy link

@janosh janosh commented Dec 31, 2020

The stable release of actions/setup-node@v2 landed two weeks ago:

https://github.com/actions/setup-node/releases/tag/v2.1.4

The stable release of `actions/setup-node@v2` landed two weeks ago:

https://github.com/actions/setup-node/releases/tag/v2.1.4
@janosh
Copy link
Author

janosh commented Dec 31, 2020

Actually I just noticed that CI with actions/setup-node@v2 fails due to npm install -g not having permission to install to /usr/local/lib/node_modules/. Probably a thing to look into.

@patrickhulce
Copy link
Collaborator

Actually I just noticed that CI with actions/setup-node@v2 fails due to npm install -g not having permission to install to /usr/local/lib/node_modules/. Probably a thing to look into.

Ah nice catch. Yeah if that's the case, we'll either stick to v1 or hold off until we see a working example in the wild of this with the correct sudo sprinkling :)

Base automatically changed from master to main February 16, 2021 17:20
@patrickhulce
Copy link
Collaborator

We're going to go ahead and close this. v1 is serving us well and until we have a compelling reason to move to v2 with validation of it working in the wild we'll continue to hold off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants