-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 breaking changes? #223
Comments
One example of breaking changes: global npm installs (see GoogleChrome/lighthouse-ci#520) |
The versions tags (v2 in this case) following the semver notion that a major version can introduce major / breaking changes. In this case, it's covered in the main readme here and there shouldn't have been breaking changes. However, it was a big set of changes code wise and implementation wise so we major versioned. On the linked example, there shouldn't have been changes that would affect All that said, a changelog is a good point. I'll leave this active and mark as a doc issue. |
The checkout action[1] has some breaking changes[2], but they should not affect this use of all default values in a public repo. Version 2 of the setup-node action[3] should have no breaking changes[4]. [1] https://github.com/actions/checkout [2] https://github.com/actions/checkout/blob/main/CHANGELOG.md [3] https://github.com/actions/setup-node [4] actions/setup-node#223
Hello @fishcharlie. Sorry for the late response. For now, we provide all necessary information about changes in release description. Does it meet your needs? |
Hello @fishcharlie. For now I'm closing the issue. If you have any concerns feel free to ping us. |
Please reopen or add a CHANGELOG.md file, even if it only leads to this issue If you don't want to do something too big, a changelog that only lists breaking changes is good enough, IMHO. |
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.27.0 to 4.28.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.28.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
There is currently no CHANGELOG file for this repo. So it's very difficult to see breaking changes for v2.
I looked through the releases page, and all of the information seems pretty broad and doesn't give a lot of detail into what breaking changes exist in v2 compared to v1.
Therefore, 2 questions:
incompatible API changes
exist between v1 and v2? ie. what changes do I need to make to my system(s) to update from v1 to v2?The text was updated successfully, but these errors were encountered: