Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 breaking changes? #223

Closed
fishcharlie opened this issue Jan 4, 2021 · 5 comments
Closed

v2 breaking changes? #223

fishcharlie opened this issue Jan 4, 2021 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@fishcharlie
Copy link
Contributor

There is currently no CHANGELOG file for this repo. So it's very difficult to see breaking changes for v2.

I looked through the releases page, and all of the information seems pretty broad and doesn't give a lot of detail into what breaking changes exist in v2 compared to v1.

Therefore, 2 questions:

  1. Does this package follow SEMVER?
  2. If so, what incompatible API changes exist between v1 and v2? ie. what changes do I need to make to my system(s) to update from v1 to v2?
@janosh
Copy link

janosh commented Jan 14, 2021

One example of breaking changes: global npm installs (see GoogleChrome/lighthouse-ci#520)

@bryanmacfarlane
Copy link
Member

The versions tags (v2 in this case) following the semver notion that a major version can introduce major / breaking changes.

In this case, it's covered in the main readme here and there shouldn't have been breaking changes. However, it was a big set of changes code wise and implementation wise so we major versioned.

On the linked example, there shouldn't have been changes that would affect npm install -g - seems more like a permisions / runner change that would affect permissions. The only thing that changed between v1 and v2 is how we acquire the targz before extracting.

All that said, a changelog is a good point. I'll leave this active and mark as a doc issue.

@bryanmacfarlane bryanmacfarlane self-assigned this Feb 24, 2021
@bryanmacfarlane bryanmacfarlane added the documentation Improvements or additions to documentation label Feb 24, 2021
jasonaowen added a commit to jasonaowen/tinypg that referenced this issue May 22, 2021
The checkout action[1] has some breaking changes[2], but they should not
affect this use of all default values in a public repo.

Version 2 of the setup-node action[3] should have no breaking
changes[4].

[1] https://github.com/actions/checkout
[2] https://github.com/actions/checkout/blob/main/CHANGELOG.md
[3] https://github.com/actions/setup-node
[4] actions/setup-node#223
@dmitry-shibanov
Copy link
Contributor

Hello @fishcharlie. Sorry for the late response. For now, we provide all necessary information about changes in release description. Does it meet your needs?

@dmitry-shibanov
Copy link
Contributor

Hello @fishcharlie. For now I'm closing the issue. If you have any concerns feel free to ping us.

@Vadorequest
Copy link

Vadorequest commented Sep 22, 2023

Please reopen or add a CHANGELOG.md file, even if it only leads to this issue
Updating deps is a pain, not knowing what we might break by changing actions/setup-node@v2 to actions/setup-node@v3 in our workflows creates too much pressure.

If you don't want to do something too big, a changelog that only lists breaking changes is good enough, IMHO.

deining pushed a commit to deining/setup-node that referenced this issue Nov 9, 2023
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.27.0 to 4.28.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.28.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

5 participants