Report not downloaded when site is accessed using IP address

[swejaljain]

Bug report

Provide the steps to reproduce

1. Add lighthouse as chrome's extension.
2. Access the web application with server's IP.
3. Open the chrome's console
4. Go to Audit Tab and start lighthouse scanning.
5. Report is displayed in the console.
6. Click on the download report icon but nothing happens.
   P.S. If the same site is accessed on local machine with localhost using the same steps then report json is downloaded successfully.

What is the current behavior?

Report is nor downloaded on click of download report icon when web application is accessed with server IP.

What is the expected behavior?

Report should be downloaded on click of download report icon despite of the url.

Environment Information

• Lighthouse extension version : 3.0.1
• Operating System: windows
• Chrome version : Version 67.0.3396.99

Related issues
None

[patrickhulce]

I have no problem downloading a report for a server IP, we have reports of the JSON just not downloading sometimes though (#5638 #5047) perhaps its being flaky?

[patrickhulce]

Also FYI, the Chrome Extension is accessed separately. Your step description indicates you're actually using v2.9 of Lighthouse built-in to DevTools. Does everything work as expected if you use v3 in Chrome Canary?

[swejaljain]

Oh yes that's the mistake at my end I just got confused in extension and the built in dev tool. I am facing this issue every time when I am downloading the report from chrome console [you are right I am using v2.9 built in lighthouse]. I haven't check this on v3 in Chrome Canary will check and update.

[swejaljain]

I have tried the same on v3 in Chrome Canary but again the results are same on using localhost I am able to download the report json but on changing the localhost to IP report is not downloaded. I am not sure what is going wrong in my case. :(

[patrickhulce]

Hm, it might be Windows specific then. I'm not able to reproduce on Mac. We'll have to look into it.

[justinribeiro]

@patrickhulce I fired up a VM and I can reproduce this on Windows 10 in M67/ LH2.9.1 for one specific case that I believe potentially matches the above. Windows appears to have an issue with an ip address with a host port (x.x.x.x:nnnn); this doesn't throw an error in while debugging, but it never pops the Save As... dialog.

A plain no-port IP address appears to work fine, though the colon in other instances also causes odd behavior. As an example localhost:8081 causes the save dialog to remove the localhost:

This is likely because filenames in Windows can not have colons (it's a reserved character, per docs).

[patrickhulce]

Awesome thanks so much for digging in @justinribeiro! 👍

[patrickhulce]

CL is up :) https://chromium-review.googlesource.com/c/chromium/src/+/1132136

[swejaljain]

Thank you so much for your quick responses and resolutions @patrickhulce @justinribeiro :) :)

[wardpeet]

@swejaljain it's fixed in latest canary.

[swejaljain]

@wardpeet thank you for the fix :)