DevTools: sanitize audits filename before download

BUG=GoogleChrome/lighthouse#5633 Change-Id: I58fc3d6541bfab6305936f5e5f5034b4bcfdaae1 Reviewed-on: https://chromium-review.googlesource.com/1132136 Reviewed-by: Dmitry Gozman <[email protected]> Commit-Queue: Patrick Hulce <[email protected]> Cr-Commit-Position: refs/heads/master@{#573937}
binaryage · Jul 10, 2018 · ea38cb7 · ea38cb7
1 parent 9b217af
commit ea38cb7
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/front_end/audits2/Audits2ReportSelector.js b/front_end/audits2/Audits2ReportSelector.js
@@ -136,9 +136,10 @@ Audits2.ReportSelector.Item = class {
   }
 
   download() {
-    const url = new Common.ParsedURL(this._lighthouseResult.finalUrl).domain();
+    const domain = new Common.ParsedURL(this._lighthouseResult.finalUrl).domain();
+    const sanitizedDomain = domain.replace(/[^a-z0-9.-]+/gi, '_');
     const timestamp = this._lighthouseResult.fetchTime;
-    const fileName = `${url}-${new Date(timestamp).toISO8601Compact()}.json`;
+    const fileName = `${sanitizedDomain}-${new Date(timestamp).toISO8601Compact()}.json`;
     Workspace.fileManager.save(fileName, JSON.stringify(this._lighthouseResult), true);
   }
 };