core: truncate measure timings to hundredths #7748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
brendankenny,
patrickhulce and
paulirish
as code owners
|
Wait, wrong timings :) |
connorjclark
force-pushed
the
truncate-timings
branch
from
4cec797 to
4d1c288
Compare
connorjclark
changed the title
paulirish
approved these changes
Mar 27, 2019
lighthouse-core/runner.js
Outdated
| @@ -180,6 +180,12 @@ class Runner { | |||
| // As entries can share a name, dedupe based on the startTime timestamp | |||
| ].map(entry => /** @type {[number, PerformanceEntry]} */ ([entry.startTime, entry])); | |||
| const timingEntries = Array.from(new Map(timingEntriesKeyValues).values()); | |||
| for (const timing of timingEntries) { | |||
There was a problem hiding this comment.
add a comment above this loop to explain why this is being done.
lighthouse-core/runner.js
Outdated
| @@ -180,6 +180,12 @@ class Runner { | |||
| // As entries can share a name, dedupe based on the startTime timestamp | |||
| ].map(entry => /** @type {[number, PerformanceEntry]} */ ([entry.startTime, entry])); | |||
| const timingEntries = Array.from(new Map(timingEntriesKeyValues).values()); | |||
| for (const timing of timingEntries) { | |||
| // @ts-ignore - ignore readonly | |||
| timing.startTime = parseFloat(timing.startTime.toFixed(2)); | |||
There was a problem hiding this comment.
It looks like you may have to make a copy of these in order to do this. Real PerformanceEntry's properties really do appear to be read only
paulirish
approved these changes
Mar 29, 2019
|
shout out to @wardpeet who made extension-test a thing! that failure was so rad. :D |
|
hip hip hurray!! @wardpeet is like, the best example of open source awesomeness around 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces LHR size by ~4KB. That was ~1% of the LHR I tested it with.
Related Issues/PRs
#7160