Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: truncate measure timings to hundredths #7748

Merged
merged 2 commits into from
Mar 29, 2019
Merged

core: truncate measure timings to hundredths #7748

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d1c288
core: truncate measure timings to hundredths
connorjclark Mar 27, 2019
10ba599
add comment, dont modify readonly obj
connorjclark Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lighthouse-core/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,12 @@ class Runner {
// As entries can share a name, dedupe based on the startTime timestamp
].map(entry => /** @type {[number, PerformanceEntry]} */ ([entry.startTime, entry]));
const timingEntries = Array.from(new Map(timingEntriesKeyValues).values());
for (const timing of timingEntries) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment above this loop to explain why this is being done.

// @ts-ignore - ignore readonly
timing.startTime = parseFloat(timing.startTime.toFixed(2));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you may have to make a copy of these in order to do this. Real PerformanceEntry's properties really do appear to be read only

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeaup.
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

// @ts-ignore - ignore readonly
timing.duration = parseFloat(timing.duration.toFixed(2));
}
const runnerEntry = timingEntries.find(e => e.name === 'lh:runner:run');
return {entries: timingEntries, total: runnerEntry && runnerEntry.duration || 0};
}
Expand Down