misc(release): delete lighthouse pristine folder to keep it fresh #9664
Conversation
| if [[ ! -e lighthouse-pristine/ ]]; then | ||
| git clone [email protected]:GoogleChrome/lighthouse.git lighthouse-pristine | ||
| fi | ||
| # Delete the folder if it already exists. We need it super fresh |
There was a problem hiding this comment.
:( that's what git clean -fdx is supposed to accomplish, does it not work?
There was a problem hiding this comment.
patrick, for context @exterkamp ran into an inexplicable bug (dbw smokes failing because /zone.js request was 404ing, only via test.sh) which resolved itself after the first time the folder was deleted. We were never able to repro again ...
There was a problem hiding this comment.
hm, that's so weird. alright then thanks for the explanation! :)
| git clone [email protected]:GoogleChrome/lighthouse.git lighthouse-pristine | ||
| fi | ||
| # Delete the folder if it already exists. We need it super fresh | ||
| rm -rf lighthouse-pristine |
There was a problem hiding this comment.
should be able to get rid of pretty much all the git commands after this then
|
|
||
| git clone [email protected]:GoogleChrome/lighthouse.git lighthouse-pristine | ||
| cd lighthouse-pristine/ | ||
|
|
||
| if [[ -n "$(git status --porcelain)" ]]; then |
There was a problem hiding this comment.
should we move this warning about the rm -rf to prevent accidental deletion?
last time I ran the release scripts (maybe 5.0? I think I just did it manually for 5.2 :) I think I remember the zone.js issue being something different. Was the error happening in the You can see this in a random directory with just the version on npm if you do npm init -y
npm install lighthouse
npm explore lighthouse -- npm run smoke pwa # no problem
npm explore lighthouse -- npm run smoke dbw # extra console error due to zone.js 404 |
|
@brendankenny figured it out :) maybe we should have a --skip-test flag for smokes |
|
no on this one after #9672? |
No description provided.