Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(release): delete lighthouse pristine folder to keep it fresh #9664

Closed
wants to merge 1 commit into from
Closed

misc(release): delete lighthouse pristine folder to keep it fresh #9664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lighthouse-core/scripts/release/prepare-pristine.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ set -euxo pipefail
# Setup a pristine git environment
cd ../

if [[ ! -e lighthouse-pristine/ ]]; then
git clone [email protected]:GoogleChrome/lighthouse.git lighthouse-pristine
fi
# Delete the folder if it already exists. We need it super fresh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:( that's what git clean -fdx is supposed to accomplish, does it not work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not clean enough.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patrick, for context @exterkamp ran into an inexplicable bug (dbw smokes failing because /zone.js request was 404ing, only via test.sh) which resolved itself after the first time the folder was deleted. We were never able to repro again ...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, that's so weird. alright then thanks for the explanation! :)

rm -rf lighthouse-pristine
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be able to get rid of pretty much all the git commands after this then


git clone [email protected]:GoogleChrome/lighthouse.git lighthouse-pristine
cd lighthouse-pristine/

if [[ -n "$(git status --porcelain)" ]]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we move this warning about the rm -rf to prevent accidental deletion?

Expand Down