Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OTel the default for metrics #2859

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Make OTel the default for metrics #2859

merged 1 commit into from
Jan 7, 2025

Conversation

kislaykishore
Copy link
Collaborator

@kislaykishore kislaykishore commented Jan 6, 2025

Description

Use OTel for metrics by default. One can override the behavior to use OpenCensus instead by setting --enable-otel flag to false.

Link to the issue in case of a bug fix.

b/387898221

Perf impact:

Branch File Size Read BW Write BW RandRead BW RandWrite BW
Master 0.25MiB 452.23MiB/s 1.16MiB/s 63.39MiB/s 1.29MiB/s
PR 0.25MiB 465.06MiB/s 1.33MiB/s 65.42MiB/s 1.29MiB/s
Master 48.828MiB 3757.51MiB/s 77.25MiB/s 1176.68MiB/s 79.37MiB/s
PR 48.828MiB 3832.38MiB/s 80.22MiB/s 1209.13MiB/s 81.02MiB/s
Master 976.562MiB 3906.58MiB/s 29.89MiB/s 443.78MiB/s 33.62MiB/s
PR 976.562MiB 3897.71MiB/s 33.91MiB/s 573.08MiB/s 32.56MiB/s

Testing details

  1. Manual - Tested the Prometheus endpoint.
  2. Unit tests - NA
  3. Integration tests - Covered by existing tests

@kislaykishore kislaykishore requested a review from a team as a code owner January 6, 2025 08:23
@kislaykishore kislaykishore added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Jan 6, 2025
@kislaykishore kislaykishore requested review from a team, gargnitingoogle and tritone and removed request for a team and gargnitingoogle January 6, 2025 08:23
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.11%. Comparing base (cec1b20) to head (488d6b0).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2859      +/-   ##
==========================================
+ Coverage   76.08%   76.11%   +0.03%     
==========================================
  Files         118      118              
  Lines       16557    16557              
==========================================
+ Hits        12598    12603       +5     
+ Misses       3427     3423       -4     
+ Partials      532      531       -1     
Flag Coverage Δ
unittests 76.11% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kislaykishore kislaykishore changed the title Enable OTel metrics by default Use OTel metrics by default Jan 7, 2025
@kislaykishore kislaykishore changed the title Use OTel metrics by default Make OTel the default for metrics Jan 7, 2025
@kislaykishore kislaykishore merged commit 94c5ebd into master Jan 7, 2025
19 checks passed
@ashmeenkaur ashmeenkaur deleted the enable-otel branch January 7, 2025 06:40
kislaykishore added a commit that referenced this pull request Jan 8, 2025
kislaykishore added a commit that referenced this pull request Jan 8, 2025
kislaykishore added a commit that referenced this pull request Feb 3, 2025
kislaykishore added a commit that referenced this pull request Feb 4, 2025
* Reapply "Enable OTel metrics by default (#2859)"

This reverts commit 11f5461.

* Fix metrics test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests execute-perf-test Execute performance test in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants