Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enable OTel metrics by default (#2859)" #2882

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

kislaykishore
Copy link
Collaborator

This reverts commit 94c5ebd.

Description

  • This is causing some of the periodic tests to fail. These tests fetch the metrics using certain attributes that are valid only in the opencensus world. At the moment, I don't have bandwidth to check this. So, reverting it.

Link to the issue in case of a bug fix.

b/387898221

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@kislaykishore kislaykishore requested a review from a team as a code owner January 8, 2025 11:25
@kislaykishore kislaykishore added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Jan 8, 2025
@kislaykishore kislaykishore requested review from a team, tritone and gargnitingoogle and removed request for a team and tritone January 8, 2025 11:26
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.22%. Comparing base (440fce6) to head (11f5461).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2882      +/-   ##
==========================================
+ Coverage   76.11%   76.22%   +0.11%     
==========================================
  Files         118      118              
  Lines       16600    16637      +37     
==========================================
+ Hits        12635    12682      +47     
+ Misses       3431     3424       -7     
+ Partials      534      531       -3     
Flag Coverage Δ
unittests 76.22% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kislaykishore kislaykishore merged commit 44d436d into master Jan 8, 2025
18 checks passed
@kislaykishore kislaykishore deleted the revert-otel-default branch January 8, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests execute-perf-test Execute performance test in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants