Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terraform]: Add provider version to useragent. #891

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Nov 9, 2018

hashicorp/terraform-provider-google#2438

hashicorp/terraform-provider-azurerm#2032


[all]

[terraform]

Add provider version to useragent.

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#117
depends: hashicorp/terraform-provider-google#2442

@nat-henderson
Copy link
Contributor

This is going to be a hassle for us on tracking - is it possible to make the new output strings more like the current ones, so the current regexes we use to extract tool & version still work?

e.g. Terraform/1.19.0-beta (+terraform.io)?

@rileykarson rileykarson force-pushed the provider-version-useragent branch from 842fedf to 9279a7b Compare November 13, 2018 23:16
@rileykarson
Copy link
Member Author

Discussed offline - this should work with our existing regexes.

I flipped around the arguments so that we are shaped like this:

Terraform/0.11.7 (+https://www.terraform.io) terraform-provider-google-beta/dev

instead of:

Terraform/0.11.7 terraform-provider-google-beta/dev (+https://www.terraform.io)

This is closer to the format used by browsers such as Chrome where each product has one of these shapes, and products are in a list:

{{PRODUCT}}/{{VERSION}}
{{PRODUCT}}/{{VERSION}} ({{COMMENT}})

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 8cc4d8f) have been included in your existing downstream PRs.

rileykarson and others added 3 commits November 14, 2018 00:04
@modular-magician modular-magician force-pushed the provider-version-useragent branch from 9279a7b to eb5b156 Compare November 14, 2018 00:04
@modular-magician modular-magician merged commit 5885b68 into GoogleCloudPlatform:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants