Add new version.go file + linker flags. #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2018
|
Make sure the user agent changes fit in with the work @ndmckinley is doing with user agents. |
|
Yep! He'll be the reviewer on the MM-side PR. |
paultyng
approved these changes
Nov 9, 2018
|
Thanks Paul! |
rileykarson
added a commit
to hashicorp/terraform-provider-google-beta
that referenced
this pull request
Nov 9, 2018
nat-henderson
pushed a commit
that referenced
this pull request
Dec 4, 2018
nat-henderson
pushed a commit
that referenced
this pull request
Dec 5, 2018
nat-henderson
pushed a commit
to hashicorp/terraform-provider-google-beta
that referenced
this pull request
Dec 6, 2018
nat-henderson
pushed a commit
that referenced
this pull request
Dec 6, 2018
nat-henderson
pushed a commit
to hashicorp/terraform-provider-google-beta
that referenced
this pull request
Dec 12, 2018
nat-henderson
pushed a commit
that referenced
this pull request
Dec 13, 2018
nat-henderson
pushed a commit
that referenced
this pull request
Dec 21, 2018
nat-henderson
pushed a commit
that referenced
this pull request
Dec 21, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Paul!
We're interested in getting the binary version of the Google provider(s) in our user agent strings, similar to the change you made in hashicorp/terraform-provider-azurerm#2032.
Your comment mentions that the version is set during the release process. Is that something that we automatically pick up across
googleandgoogle-betawith similar changes, or will you/ @paddycarver need to do something manual on your side?This PR sets up the
version.gofile, I've made a PR with Magic Modules to exclude that file from our generation, and I'll send a PR using the new value as a followup (unfortunately, I think I can only send out that PR after this one lands because we only generate if the provider can successfully build).