Merge pull request #739 from dzoeteman/build-args-cache

Reverted not including build args in cache key
GoogleContainerTools · Aug 16, 2019 · 48e25aa · 48e25aa
2 parents a111681 + c425f02
commit 48e25aa
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/pkg/executor/build.go b/pkg/executor/build.go
@@ -191,6 +191,7 @@ func (s *stageBuilder) optimize(compositeKey CompositeCache, cfg v1.Config) erro
 func (s *stageBuilder) build() error {
 	// Set the initial cache key to be the base image digest, the build args and the SrcContext.
 	compositeKey := NewCompositeCache(s.baseImageDigest)
+	compositeKey.AddKey(s.opts.BuildArgs...)
 
 	// Apply optimizations to the instructions.
 	if err := s.optimize(*compositeKey, s.cf.Config); err != nil {