Reverted not including build args in cache key #739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#639 removed adding the build args to the cache key. This caused build args to not be considered in at least certain scenarios for caching. An example:
Running this build without build arg first, would result in
test1
in the/testfile
file. However, on subsequent builds with caching, even when including--build-arg "testarg=true"
, would still result totest1
in the/testfile
file.I've decided to simply revert the change. This seems to work correctly, and cached layers are still used if the build args are not different.
While a better solution might need to be researched long-term, I think this is not a bad solution to fix the current regression.
Fixes #690
Fixes #728