-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix copying root #1724
Fix copying root #1724
Conversation
1cef2ac
to
6869330
Compare
6869330
to
f7fc5c3
Compare
2ce34ef
to
a5d2d8d
Compare
a5d2d8d
to
d43b732
Compare
PR rebased to
source code of fork in |
161fe20
to
d10130b
Compare
02bcf48
to
63062c7
Compare
2295366
to
607036e
Compare
a108d28
to
a509373
Compare
a509373
to
0f66552
Compare
@kvaps any movement on this? Do you need help w last mile? |
@kvaps would you be able to rebase the PR here? Would like to get this in if possible, thanks! |
Submitted this PR here #2592 which rebases the changes here. Closing and moving the conversation over that PR. Feel free to re-submit, re-open, discuss, etc. if you would like to own this going in - thanks! |
Fixes #960
Description
This PR updates otiai10/copy module from v1.0.2 to v1.6.0.
Adds option to not copying ignored paths for CopyFileOrSymlink which solves two problems at once:
It might need rebase after merging #1725.
This branch includes both fixes:
kvaps:fix-copying-root-and-ownership
; compiled docker images:Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.