-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve issue around copying root #2592
Conversation
This branch still has issues for me. Without the fix:
With the fix:
|
Now that #2863 has been merged, the above issue with files in /kaniko has been fixed. Would it be possible to look into merging this (@aaron-prindle)? |
I just encountered the same issue with multi-stage builds that use layer squashing via the |
I was wondering if there was a possible idea of when this PR will be merged. |
@aaron-prindle were the issues mentioned fixed for this MR to be closed without a merge? |
@JeromeJu / @QuanZhang-William : It seems this PR has been closed without merging it into the main branch. This fix is related to #960 , which is currently a blocker for flattening (and reducing the size of) images. EDIT: Just saw you two are out of the maintainer list as well, my apologies... |
+1, this is an important feature, also to help remove security issues from container scanning (copying the fs will remove security findings from layers) |
Changes taken from @kvaps PR here: #1724. Re-submitting here as that PR required rebasing and was no longer active there. Original description added below:
Fixes #960
Description
This PR updates otiai10/copy module from v1.0.2 to v1.6.0.
Adds option to not copying ignored paths for CopyFileOrSymlink which solves two problems at once:
It might need rebase after merging #1725.
This branch includes both fixes:
kvaps:fix-copying-root-and-ownership
; compiled docker images:Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.
Additional ideas here related to this:
#960 (comment)