Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for kaniko pushretry #6211

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

elnoro
Copy link
Contributor

@elnoro elnoro commented Jul 14, 2021

Fixes: #5967
Related: none
Merge before/after: none

Description
Added support for --push-retry flag in Kaniko. Nothing major, just filled in a new constant, a new unit test and changed the api docs.

User facing changes (remove if N/A)

New configuration option pushRetry in the kaniko section.

@elnoro elnoro requested a review from a team as a code owner July 14, 2021 18:07
@elnoro elnoro requested a review from gsquared94 July 14, 2021 18:07
@google-cla google-cla bot added the cla: yes label Jul 14, 2021
@tejal29
Copy link
Contributor

tejal29 commented Jul 14, 2021

@elnoro skaffold team just did a release. Can you please submit a PR for freezing the earlier config and create a new one.
Steps here: https://github.com/GoogleContainerTools/skaffold/blob/master/DEVELOPMENT.md#making-a-config-change

@elnoro
Copy link
Contributor Author

elnoro commented Jul 15, 2021

Hello @tejal29

Thank you! Sure, I can do that - but I thought v20 is the new version? It says "Safe to modify" on L28 in config.go

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #6211 (8067a9d) into master (e02a80d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6211      +/-   ##
==========================================
- Coverage   70.81%   70.80%   -0.01%     
==========================================
  Files         482      482              
  Lines       21874    21876       +2     
==========================================
  Hits        15490    15490              
- Misses       5392     5393       +1     
- Partials      992      993       +1     
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/v1/config.go 62.16% <ø> (ø)
pkg/skaffold/build/kaniko/args.go 95.55% <100.00%> (+0.10%) ⬆️
pkg/skaffold/util/tar.go 52.87% <0.00%> (-4.60%) ⬇️
pkg/skaffold/docker/parse.go 88.23% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02a80d...8067a9d. Read the comment docs.

@tejal29
Copy link
Contributor

tejal29 commented Jul 15, 2021

yep! I think someone made a PR to freeze config after.

@tejal29 tejal29 enabled auto-merge (squash) July 15, 2021 16:55
@briandealwis briandealwis added the kokoro:run runs the kokoro jobs on a PR label Jul 16, 2021
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jul 16, 2021
@tejal29 tejal29 merged commit 7f3637b into GoogleContainerTools:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kaniko push-retry
4 participants