Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kaniko flag --image-fs-extract-retry #6380

Merged

Conversation

RabidFire
Copy link
Contributor

Hi! My first pull request here 👋

Related:

Description
Adds support for a newly introduced Kaniko flag, --image-fs-extract-retry. This is important for GCB users, as builds fail often and need to be retried by hand without this flag.

User facing changes
New configuration option imageFSExtractRetry in the kaniko section.

Side Note: I wanted to play with the --cache-copy-layers flag as well, but this is also missing. Perhaps the previous architecture where the user could add additionalFlags themselves was better (changed here). It would definitely be useful to be able to add custom flags without waiting for a skaffold release.

@RabidFire RabidFire requested a review from a team as a code owner August 7, 2021 09:46
@RabidFire RabidFire requested a review from gsquared94 August 7, 2021 09:46
@google-cla google-cla bot added the cla: yes label Aug 7, 2021
@codecov
Copy link

codecov bot commented Aug 7, 2021

Codecov Report

Merging #6380 (7d1ea3b) into main (84367d9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6380   +/-   ##
=======================================
  Coverage   70.38%   70.39%           
=======================================
  Files         499      499           
  Lines       22722    22724    +2     
=======================================
+ Hits        15994    15996    +2     
  Misses       5685     5685           
  Partials     1043     1043           
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/v1/config.go 62.16% <ø> (ø)
pkg/skaffold/build/kaniko/args.go 95.65% <100.00%> (+0.09%) ⬆️
pkg/skaffold/docker/parse.go 87.39% <0.00%> (-0.85%) ⬇️
pkg/skaffold/util/tar.go 65.51% <0.00%> (+2.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84367d9...7d1ea3b. Read the comment docs.

Copy link
Contributor

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@gsquared94
Copy link
Contributor

Perhaps the previous architecture where the user could add additionalFlags themselves was better (changed here). It would definitely be useful to be able to add custom flags without waiting for a skaffold release.

@tejal29 should we bring back additionalFlags to support arbitrary flags in addition to the typed ones?

@tejal29
Copy link
Contributor

tejal29 commented Aug 10, 2021

Perhaps the previous architecture where the user could add additionalFlags themselves was better (changed here). It would definitely be useful to be able to add custom flags without waiting for a skaffold release.

@tejal29 should we bring back additionalFlags to support arbitrary flags in addition to the typed ones?

we should definitely discuss this and keep is same across all tool config (docker, kubectl, etc)

@tejal29 tejal29 added the kokoro:force-run forces a kokoro re-run on a PR label Aug 10, 2021
@tejal29 tejal29 enabled auto-merge (squash) August 10, 2021 21:21
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Aug 10, 2021
@tejal29 tejal29 merged commit c9714c5 into GoogleContainerTools:main Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants