-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Kaniko flag --image-fs-extract-retry #6380
Add support for Kaniko flag --image-fs-extract-retry #6380
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6380 +/- ##
=======================================
Coverage 70.38% 70.39%
=======================================
Files 499 499
Lines 22722 22724 +2
=======================================
+ Hits 15994 15996 +2
Misses 5685 5685
Partials 1043 1043
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
@tejal29 should we bring back |
we should definitely discuss this and keep is same across all tool config (docker, kubectl, etc) |
Hi! My first pull request here 👋
Related:
Description
Adds support for a newly introduced Kaniko flag,
--image-fs-extract-retry
. This is important for GCB users, as builds fail often and need to be retried by hand without this flag.User facing changes
New configuration option
imageFSExtractRetry
in the kaniko section.Side Note: I wanted to play with the
--cache-copy-layers
flag as well, but this is also missing. Perhaps the previous architecture where the user could add additionalFlags themselves was better (changed here). It would definitely be useful to be able to add custom flags without waiting for a skaffold release.