Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Kaniko flag --cache-copy-layers #6703

Merged

Conversation

callahanca
Copy link
Contributor

Related: #6380 references adding this flag and was used as a reference for this PR.

Description

Add Kaniko's "--cache-copy-layers" flag (https://github.com/GoogleContainerTools/kaniko#--cache-copy-layers), which tells Kaniko to cache COPY layers.

User facing changes

New option cacheCopyLayers in kaniko section

@callahanca callahanca requested a review from a team as a code owner October 7, 2021 16:16
@callahanca callahanca requested a review from tejal29 October 7, 2021 16:16
@google-cla
Copy link

google-cla bot commented Oct 7, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 7, 2021
@callahanca
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 7, 2021
@tejal29
Copy link
Contributor

tejal29 commented Oct 7, 2021

@callahanca Thank you for your PR. Please hold off until the #6702 goes in.

@tejal29
Copy link
Contributor

tejal29 commented Oct 12, 2021

@callahanca Can you please refer to the steps here to add new config to already released config.

@tejal29
Copy link
Contributor

tejal29 commented Oct 14, 2021

Thanks @callahanca. Will review once #6730 is in

@callahanca callahanca force-pushed the kaniko-cache-copy-layers branch from b4647c7 to 9bed237 Compare October 14, 2021 21:10
@callahanca
Copy link
Contributor Author

Thanks @tejal29! I also went ahead and rebased off of main.

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #6703 (a9df811) into main (290280e) will decrease coverage by 0.84%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6703      +/-   ##
==========================================
- Coverage   70.48%   69.63%   -0.85%     
==========================================
  Files         515      527      +12     
  Lines       23150    24093     +943     
==========================================
+ Hits        16317    16778     +461     
- Misses       5776     6212     +436     
- Partials     1057     1103      +46     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 89.00% <0.00%> (-1.82%) ⬇️
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
cmd/skaffold/app/cmd/cmd.go 70.32% <66.66%> (-0.73%) ⬇️
cmd/skaffold/app/cmd/debug.go 100.00% <100.00%> (ø)
pkg/skaffold/initializer/build/builders.go 42.85% <0.00%> (-17.15%) ⬇️
pkg/skaffold/build/cluster/logs.go 0.00% <0.00%> (-16.67%) ⬇️
pkg/skaffold/event/v2/status_check.go 85.45% <0.00%> (-14.55%) ⬇️
pkg/skaffold/kubernetes/watcher.go 67.10% <0.00%> (-14.53%) ⬇️
pkg/skaffold/log/stream/stream.go 71.42% <0.00%> (-14.29%) ⬇️
.../skaffold/kubernetes/status/resource/deployment.go 72.41% <0.00%> (-13.39%) ⬇️
... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 142f535...a9df811. Read the comment docs.

@tejal29 tejal29 added kokoro:run runs the kokoro jobs on a PR and removed needs-rebase labels Oct 15, 2021
@tejal29
Copy link
Contributor

tejal29 commented Oct 15, 2021

Thanks!

@tejal29 tejal29 enabled auto-merge (squash) October 15, 2021 18:08
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 15, 2021
@callahanca
Copy link
Contributor Author

Hm, I guess this is blocked by the kokoro build failure. I didn't really see the specific error in the kaniko_microservices test; is that a test that I can run myself locally?

@MarlonGamez
Copy link
Contributor

hey @callahanca, we were having some issues with our kaniko tests but they've been resolved now. I'll put kokoro to run again for you PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants