-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Kaniko flag --cache-copy-layers #6703
feat: add support for Kaniko flag --cache-copy-layers #6703
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
@callahanca Thank you for your PR. Please hold off until the #6702 goes in. |
@callahanca Can you please refer to the steps here to add new config to already released config. |
b8c6a53
to
b4647c7
Compare
Thanks @callahanca. Will review once #6730 is in |
b4647c7
to
9bed237
Compare
Thanks @tejal29! I also went ahead and rebased off of main. |
Codecov Report
@@ Coverage Diff @@
## main #6703 +/- ##
==========================================
- Coverage 70.48% 69.63% -0.85%
==========================================
Files 515 527 +12
Lines 23150 24093 +943
==========================================
+ Hits 16317 16778 +461
- Misses 5776 6212 +436
- Partials 1057 1103 +46
Continue to review full report at Codecov.
|
Thanks! |
Hm, I guess this is blocked by the kokoro build failure. I didn't really see the specific error in the kaniko_microservices test; is that a test that I can run myself locally? |
hey @callahanca, we were having some issues with our kaniko tests but they've been resolved now. I'll put kokoro to run again for you PR |
Related: #6380 references adding this flag and was used as a reference for this PR.
Description
Add Kaniko's "--cache-copy-layers" flag (https://github.com/GoogleContainerTools/kaniko#--cache-copy-layers), which tells Kaniko to cache COPY layers.
User facing changes
New option
cacheCopyLayers
in kaniko section