Mark ShadowJar.dependencyFilter as Input
#1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
force-pushed
the
g/20250127/more-inputs
branch
from
5af3f0a to
58564d3
Compare
Goooler
commented
Jan 28, 2025
Comment on lines
125
to
129
| @get:Internal | ||
| public open var keyTransformer: (String) -> String = IDENTITY | ||
| @Transient // Input property should be Serializable, but we don't want to serialize the lambda. | ||
| @get:Optional | ||
| @get:Input | ||
| public open var keyTransformer: ((String) -> String)? = null |
There was a problem hiding this comment.
It can't work correctly with caching, see #1208 (comment).
There was a problem hiding this comment.
Reverts this in d39b7de.
This reverts commit 58564d3.
Goooler
changed the title
InputShadowJar.dependencyFilter as Input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.