Add explicit caching test for PropertiesFileTransformer
#1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
force-pushed
the
g/20250128/add-tests-for-transformer
branch
from
036832e to
09ccc2a
Compare
This reverts commit 09ccc2a.
Goooler
changed the title
PropertiesFileTransformerPropertiesFileTransformer
Goooler
force-pushed
the
g/20250128/add-tests-for-transformer
branch
from
d0d41e8 to
fa0d5f0
Compare
Goooler
force-pushed
the
g/20250128/add-tests-for-transformer
branch
from
fa0d5f0 to
ef872cf
Compare
Goooler
commented
Jan 28, 2025
...onalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/caching/TransformerCachingTest.kt
Show resolved
Hide resolved
…0250128/add-tests-for-transformer
Goooler
commented
Jan 28, 2025
| } | ||
|
|
||
| assertFirstExecutionSuccess() | ||
| assertions("FOO") |
There was a problem hiding this comment.
expected to contain:<"FOO=bar"> but was:<"#
foo=bar
"> (com.github.jengelman.gradle.plugins.shadow.util.JarPath@5827af16)
org.opentest4j.AssertionFailedError: expected to contain:<"FOO=bar"> but was:<"#
foo=bar
This failure looks due to keyTransformer being @Transient, can't be serialized back, it's null in
There was a problem hiding this comment.
I tried a serializable type in d71e879, but with a new error
* What went wrong: |
-- | --
| com/github/jengelman/gradle/plugins/shadow/transformers/KeyTransformer |
| > com.github.jengelman.gradle.plugins.shadow.transformers.KeyTransformer |
| |
| * Try: |
| > Run with --info or --debug option to get more log output. |
| > Run with --scan to get full insights. |
| > Get more help at https://help.gradle.org. |
| |
| * Exception is: |
| java.lang.NoClassDefFoundError: com/github/jengelman/gradle/plugins/shadow/transformers/KeyTransformer
No idea how to fix them now...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1206.