Implement RegionShape.POLYGON and RegionShape.CYLINDER #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also took the opportunity to sort them in order and use multiplication instead of pow.
KingRainbow44
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kinda surprised this didn't happen sooner, but CYLINDER and POLYGON are valid region types that were never implemented.
I implemented them and took the opportunity to sort them in order and use multiplication instead of pow. (slight speed up)
Issues fixed by this PR
POLYGON is used in one quest near the chasm, and CYLINDER is used on all those dungeon waypoints that wouldn't move when you got near them.
Type of changes
Checklist: