Shared State w/ Hooks #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleknighted
force-pushed
the
react_hook_state
branch
from
c33717f to
260a184
Compare
Merged
kyleknighted
force-pushed
the
react_hook_state
branch
2 times, most recently
from
f68f776 to
7d96a53
Compare
kyleknighted
requested review from
danotorrey,
dennisoelkers,
cobaltclaudia and
kmerz
dennisoelkers
requested changes
Jul 3, 2019
kyleknighted
force-pushed
the
react_hook_state
branch
from
3c4b7a4 to
03966c4
Compare
dennisoelkers
requested changes
Jul 8, 2019
dennisoelkers
requested changes
Jul 10, 2019
| </li> | ||
| <li> | ||
| <strong>Global Input</strong> | ||
| <span>{(formData.awsCloudWatchGlobalInput && formData.awsCloudWatchGlobalInput.value) ? 'true' : 'false'}</span> |
There was a problem hiding this comment.
We could also use a glyph (checkmark/cross) in here?
| ); | ||
| } | ||
| const format = (numString) => { | ||
| return Number(numString).toLocaleString('en-US'); |
There was a problem hiding this comment.
Maybe we should leave out the locales so we are defaulting to the browser/os setting?
dennisoelkers
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bypassed the reliance of Reflux to just use Hooks to manage the state of the fields.