[gtk3] Tray icon

[ivoshm]

Only aesthetic glitch, see zoomed picture:

Manjaro Linux XFCE
package from Arch Linux guake-3.0.2+6+ge9df754-1

[gsemet]

thanks for this review.

[Ozzyboshi]

I'd like to have a new icon for guake3 to avoid confusion with older guake, I usually load them both

[aichingm]

Doesn't happen on archlinux with Kde and current HEAD

[gsemet]

is it still reproduced now we use the svg file?

[ivoshm]

Tested on 3.0.4-2 (Arch repo) and problem continue ...
... even if I removed guake-tray.png in /usr/lib/python3.6/site-packages/guake/data/pixmaps

EDIT: Problem disappeared if I set "show frame" in XFCE panel settings / SysTray - but I think it's correlated with icon size and zooming (if smaller than +/- 20 px is OK, bigger is with bug).

[shirishag75]

at the end the issue was found in GtkStatusIcon as that has been deprecated. See mate-desktop/mate-panel#666 (comment) . Somebody has issued a PR and there probably need to be some fixing up at Guake's end as well.

[muktupavels]

1. Install named icon with different sizes and use gtk_status_icon_set_from_icon_name
2. Or connect to size-changed signal and give status icon pixbuf at needed size:
   https://developer.gnome.org/gtk3/stable/GtkStatusIcon.html#GtkStatusIcon-size-changed

svg loaded with gtk_status_icon_set_from_file is not scaled up either if size is smaller then needed.

[ghost]

I get the same strange icon (see image below, centre) that others report. I am on Mint 19.0 x64 Cinnamon with Guake 3.0.5 (which is the version of Guake in my repositories).

EDIT: same problem in Mint 19.1 beta Cinnamon. (Actually in Mint 19.1 the icon exhibits a further strangeness, in that it gets squashed into the top half of the space it should be occupying. But that may be a Mint bug.)

[muktupavels]

@CottonEaster It is combination of bug in GTK and Guake providing only small icon. GTK bug is fixed, but there has not been new release with fix yet.

[ghost]

Thank you for the information though. I remain unsure about some things:

but there has not been new release with fix yet.
No new release of GTK, you mean? Also, if the answer is 'yes', then doesn't Guake itself need fixing, as you suggest?

[muktupavels]

My fix was merged in gtk:

• https://gitlab.gnome.org/GNOME/gtk/merge_requests/451
• https://gitlab.gnome.org/GNOME/gtk/commit/43aeb52b73428da919ef030a622a51ed21df4ae2

So now we need to wait until there will be new release. On IRC I read that they are planing / hope to make new release before Christmas. Then there will be some time until new release is uploaded to distributions. Distro maintainers can choose to apply patch without waiting for new release.

With GTK fix icon still will be small, but it will look correct. Guake should be fixed, because I would expect that all tray icons are same size - so small icon is bug.