Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken tray icon with Appindicators #433

Closed
cl0ne opened this issue Jan 1, 2015 · 9 comments · Fixed by #2200
Closed

Broken tray icon with Appindicators #433

cl0ne opened this issue Jan 1, 2015 · 9 comments · Fixed by #2200

Comments

@cl0ne
Copy link

cl0ne commented Jan 1, 2015

Cinnamon 2.4.5 (System Tray applet), Arch Linux, libappindicator 12.10, leftmost icon is Guake:
2015-01-01 03 07 02

As a quick-and-dirty solution I'm using

--- guake_app.py    2015-01-01 03:23:58.251836090 +0200
+++ guake_app.py.orig   2014-11-23 19:36:50.000000000 +0200
@@ -146,7 +146,7 @@
             self.tray_icon.connect('activate', self.show_hide)
         else:
             self.tray_icon = appindicator.Indicator(_("guake-indicator"), _("guake-tray"), appindicator.CATEGORY_OTHER)
-            self.tray_icon.set_icon(pixmapfile("guake-tray.png"))
+            self.tray_icon.set_icon("guake-tray")
             self.tray_icon.set_status(appindicator.STATUS_ACTIVE)
             menu = self.get_widget('tray-menu')
             show = gtk.MenuItem(_('Show'))
@gsemet gsemet added this to the 0.6.0 milestone Jan 1, 2015
@gsemet gsemet self-assigned this Jan 1, 2015
@bepvte
Copy link

bepvte commented Feb 24, 2015

Bump! Manjaro with xfce:
image
Left one is guake.

@gsemet gsemet modified the milestones: 0.6.0, 0.7.0 Apr 19, 2015
@gsemet gsemet modified the milestones: 0.7.0, 0.8.0 May 2, 2015
@sanderboom
Copy link

MATE (GTK2):
image
Most left is ... you guessed it

@Jesse-Millwood
Copy link

I don't know if this applies here or not but with Xubuntu 14.04 the original guake icon shows up in my Notification area but it does not use the icon for my theme.
selection_058

I have guake 0.7.2 on Xubuntu 14.04. For me this is just a minor annoyance. Otherwise I could not be happier with guake!

@thwarted
Copy link
Contributor

thwarted commented Aug 1, 2015

Just throwing some more information out there since I'm investigating this issue right now...

Also an issue for me on Fedora 21, xfce spin, xfce4-panel-4.10.1-6.fc21 x86_64, guake 0.7.2. It wasn't always like this, I think the package compiled by upstream that was installed on my system on July 3rd is when it started happening. From looking at the package changelog, I think this package made no local modifications.

The tool-tip "Guake Terminal" also doesn't show on my setup. That, and poking around in the code trying various things, makes me think that this is some new incompatibility with some tray related desktop environment library (which may have also been updated around the same time).

Investigation continues...

@thwarted
Copy link
Contributor

thwarted commented Aug 1, 2015

Really should have seen this sooner, it's been a long day...I was concentrating on the code in the exception handler for when import appindicator fails. On July 1st I happened to pull in the package python-appindicator as part of another package's dependency resolution, and that's what broke this for me.

The (reverse) of the patch given by @cl0ne in the original issue fixes this for me.

@gsemet gsemet modified the milestones: 0.8.1, 0.8.2 Aug 18, 2015
@gsemet gsemet modified the milestones: 0.8.2, 0.8.3 Oct 25, 2015
@gsemet gsemet modified the milestones: 0.8.4, 0.8.5 Feb 29, 2016
@gsemet gsemet modified the milestones: 0.8.5, 0.8.6 Jun 6, 2016
@gsemet gsemet modified the milestones: 0.8.6, 0.8.7 Aug 20, 2016
@gsemet gsemet modified the milestones: 0.8.8, 0.8.9 Dec 13, 2016
@gsemet gsemet modified the milestones: 0.8.9, 0.8.11 Jun 28, 2017
@gsemet gsemet removed this from the 0.8.11 milestone Jan 11, 2018
@shirishag75
Copy link

shirishag75 commented Oct 11, 2018

It looks weird in mate-panel 1.20.3 and has been looking for a long time.

I am using ayatana appindicator but still it looks weird/broken
guake-looks-weird-in-mate-panel

I did see the png files but came none the wiser -

$ dpkg -L guake | grep png
/usr/share/guake/data/pixmaps/add_tab.png
/usr/share/guake/data/pixmaps/guake-128.png
/usr/share/guake/data/pixmaps/guake-48.png
/usr/share/guake/data/pixmaps/guake-64.png
/usr/share/guake/data/pixmaps/guake-notification.png
/usr/share/guake/data/pixmaps/guake-tray.png
/usr/share/guake/data/pixmaps/guake.png
/usr/share/guake/data/pixmaps/quick-open-python-exception.png
/usr/share/guake/data/pixmaps/quick-open-selection.png
/usr/share/guake/data/pixmaps/quick-open.png
/usr/share/pixmaps/guake.png
$ mediainfo /usr/share/guake/data/pixmaps/guake-tray.png 
General
Complete name                            : /usr/share/guake/data/pixmaps/guake-tray.png
Format                                   : PNG
Format/Info                              : Portable Network Graphic
File size                                : 987 Bytes

Image
Format                                   : PNG
Format/Info                              : Portable Network Graphic
Format_Compression                       : LZ77
Width                                    : 20 pixels
Height                                   : 20 pixels
Bit depth                                : 32 bits
Compression mode                         : Lossless
Stream size                              : 987 Bytes (100%)


$ mediainfo /usr/share/guake/data/pixmaps/guake-notification.png
General
Complete name                            : /usr/share/guake/data/pixmaps/guake-notification.png
Format                                   : PNG
Format/Info                              : Portable Network Graphic
File size                                : 2.90 KiB

Image
Format                                   : PNG
Format/Info                              : Portable Network Graphic
Format_Compression                       : LZ77
Width                                    : 48 pixels
Height                                   : 38 pixels
Bit depth                                : 32 bits
Compression mode                         : Lossless
Stream size                              : 2.90 KiB (100%)

I do have libayatana appindicator installed as well.

@ivoshm
Copy link

ivoshm commented Oct 11, 2018

Looks like more general problem. If tray icon of Guake is zoomed at 21+ px, it's broken - in my case in XFCE panel (see #1110).

@shirishag75
Copy link

shirishag75 commented Oct 11, 2018

There is something called Ayatana indicators which is a continuation of appindicator and they have made something called guake-indicator as well .

Some links for more background -

https://sunweavers.net/blog/node/67

https://sunweavers.net/blog/node/24 - an older but perhaps more background info. on the need in Debian.

https://lists.debian.org/debian-devel/2018/03/msg00506.html
https://ayatanaindicators.github.io/
https://wiki.debian.org/Ayatana/IndicatorsTransition

So it seems guake needs to transition it

There is something called guake-indicator but it's a different package having somewhat different goals, it seems -

https://wiki.debian.org/Ayatana/IndicatorsTransition#Package:_guake-indicator

Guake indicator lets you send custom commands through the D-Bus System. Commands can be manually edited in a XML file under ~/.guake.indicator or generated through guake-indicator edit-menu system GUI.

From the manpage - guake-indicator lets you manage your favorite customized commands establishing a new connection with Guake dropdown terminal.

http://guake-indicator.ozzyboshi.com/

the xml file - https://paste.debian.net/1046842/

@gsemet
Copy link
Member

gsemet commented Oct 11, 2018

hi. If you feel motivated to hack the guake code to make it work on your system, I would be so glad :)

EbonJaeger added a commit to EbonJaeger/guake that referenced this issue Sep 7, 2023
This uses the newer successor to AppIndicator3 for the tray icon implementation, with a fallback to the older AppIndicator3 if the Ayatana version is not found. AyatanaAppIndicator is backwards compatible with AppIndicator3, so the API remains the same. The icon is also fixed.

Tested on Solus 4.4 with Budgie Desktop 10.8.

Ref BuddiesOfBudgie/budgie-desktop#446
Fixes Guake#433

Signed-off-by: Evan Maddock <[email protected]>
EbonJaeger added a commit to EbonJaeger/guake that referenced this issue Sep 7, 2023
This uses the newer successor to AppIndicator3 for the tray icon implementation, with a fallback to the older AppIndicator3 if the Ayatana version is not found. AyatanaAppIndicator is backwards compatible with AppIndicator3, so the API remains the same. The icon is also fixed.

Ref BuddiesOfBudgie/budgie-desktop#446
Fixes Guake#433

sem-ver: bug-fix

Signed-off-by: Evan Maddock <[email protected]>
Davidy22 pushed a commit that referenced this issue Oct 9, 2023
This uses the newer successor to AppIndicator3 for the tray icon implementation, with a fallback to the older AppIndicator3 if the Ayatana version is not found. AyatanaAppIndicator is backwards compatible with AppIndicator3, so the API remains the same. The icon is also fixed.

Ref BuddiesOfBudgie/budgie-desktop#446
Fixes #433

sem-ver: bug-fix

Signed-off-by: Evan Maddock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants