-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guake not shown in Notification area. #666
Comments
@flexiondotorg @sunweaver @lukefromdc @raveit65 @sc0w |
I don't know this app and i don't see any hints how to use it. Edit: |
I can see the guake icon in the notification area The first time I run it, it goes to the notifiaction area guake 0.8.10-1 debian testing |
I also do not have guake installed. Looks like it's just a drop-down terminal app. In synaptic I see guake and guake-indicator listed as available. Unfortunately it pulls in a bunch of dependencies so it is not very practical for me to test and then get rid of all the stuff it pulled in. If you are getting no icon but can hover between two icons, this looks like a zero icon width bug or an icon problem. In SNI mode, a missing icon will bring up the generic "missing icon" icon so that's probably not the problem. Try changing through all your themes and seeing if the icon appears. |
Yeah it's a drop-down terminal app, one of several ones out there. |
It doesn't depend on any appindicator stuff, so SNI mode is out of question. |
FWIW, guake now shows up but looks weird guake is a terminal emulator https://github.com/Guake/ |
This apparently happened right after GTK+ 3.24 replaced 3.22 in Debian Testing. I can now reproduce this icon corruption in Ubuntu 18.10 with mate-panel 1.20.3 and GTK+ 3.24.1. It's a different problem than the one reported here originally though. Do we have any other reports about it? |
@lukefromdc: I've picked the fix from #834 and built 1.20 branch with it. Had to do some manual work, the commit didn't apply cleanly... So it didn't fix this corruption of Guake icon for me. Are there some other tray fixes which aren't picked to 1.20 yet? Tested in a VM and without HiDPI. |
I really don't know at this point: I don't have anything with the full set of 1.20 packages installed, and didn't see anything obvious but there are a lot of other differences now from the wide panel work in master. Have you tested this with master (1.21) to see if there is any difference? Also, make sure you both build and run with either GTK 3.24 or GTK 3.22, don't mix these up. |
I just verified by a test install over master that whatever this is, it is not a cherrypicking issue. I wonder however if the problem is in Guake itself and NOT in the panel, as the icon for a status icon is set up by the application setting a GtkStatusIcon and the contents of the small window containing it are what get passed to the GtkSocket using Xembed. Got these results on first a small, then a large panel, with only a tiny sub 16px icon working right: |
Also note that a guake-indicator package is now available(at least in Debian and presumably Ubuntu). Install this and have it start at login rather than guake itself, and it will start an instance of guake. Turn off guake's own tray icon in preferences(right click the guake terminal to get there without the icon) and you are done. This is a workaround, not a fix, but I strongly suspect the issue is in guake and not in mate-panel with the tray icon. |
I don't mix GTK+ versions, every VM has its own version from the corresponding Debian/Ubuntu release. So I've tested in a few other configurations too.
It's reproducible in all these cases. So could be indeed Guake's own problem... |
Ok, so this is already reported at Guake/guake#1110, and it happens in Xfce too. This is only about Guake 3.x.x releases which are GTK+3. The original problem reported here is about older versions of Guake (0.8.x) which are GTK+2. I was never able to reproduce the issue. Given all this, should we close this report? |
OK, we can probably close this, as the same issue with GTK3 versions of Guake is being reported across multiple DE's with different trays. Some of this may be maintainance issues with GtkStatusIcon or GtkPlug/Socket themselves, I would imagine Xembed itself is properly taken care of. This also tells me that tray issues with mate-power-management and with the mate volume control applet may need some work on our part in those packages. Since there are at least some status icons that render troublefree , we may just have to limit what we ourselves now do with GtkStatusIcon to those things that still work correctly. That was why I dropped my effort to add an icon and slider for recording from output sound to mate-media's volume control applet: I just could not make the icon reliable with how GtkStatusIcon is behaving these days. |
mate-desktop/mate-indicator-applet#21 and the fix for it in |
Yeah, GtkStatusIcon is deprecated, so they probably don't add any fixes to it. |
The icon tiling issue in GTK 3 turned out to indeed be a gtkstatusicon issue, for which a PR has been submitted to GTK 3.24 and fixed it in my testing: See #793 (comment) |
umm... so what do we as users do now, wait for a new gtk+ release to come out or guake upstream also needs to do some fixing ? I noticed the same issue in lxqt as well :( |
No change needed in Guake, if the GTK devs merge the fix it should make it into GTK 3.24.3. Note that GTK 3.24.2 just came out today, only to be followed by a commit to revert a commit that broke the entire build. Thus the possible scenarios are: Also, if your distro uses GTK 3.22, I have no idea if this would ever be backported. Note that mate-panel and some other programs have to be rebuilt for GTK 3.24 if you want to get good results on a HiDPI screen but will work fine on a normal resolution screen without rebuilding. |
that really depends upon Debian. Debian will enter soft freeze at Feb. end but might make an exception depending on when it's released. We are currently at -
so a point release should be doable. Actually they just pushed the new release in debian sid as well. https://alioth-lists.debian.net/pipermail/pkg-gnome-maintainers/2018-December/148573.html so we now have 3.24-2 as well. |
Fix in GTK 3.24 branch is now merged, so its just a matter of waiting for GTK 3.24.3 which should include it. |
There might be new release before Christmas. :) |
please intimate if it happens so. There is a delay in getting gtk 3.24.2 . If gtk 3.24.3 gets released, could ask the Debian Developers (DD) who are maintaining that package to get the release and see how guake icon looks afterwards in mate-panel, xfce-panel and lxqt, all in which guake fails at the present to give nice icon in the system tray. |
GTK 3.24.2 as initially tagged had a commit with a typo that broke the build, thus no surprise it has not appeared as a released build. |
In Debian they did use the patch which fixed the typo and released it yesterday/today. See https://tracker.debian.org/news/1011105/accepted-gtk30-3242-3-source-into-unstable/ |
To get this into Debian Stable and other releases that predate GTK 3.24 would require a cherrypick into GTK 3.22, assuming the commits would apply clean-or for distros to apply it as a patch. That would clean up a lot of ugly rendering for a lot of people I suspect. |
You can try to ask that they add one more patch. |
They could make a patch that works with 3.22 and release it as 3.22.1 . With git there is never an issue of doing something like that and happens all the time. If nobody else puts up a request, I will do the same in few hours. If somebody else does, please intimate the same. |
I think they have stated (I might be wrong) that there won't be new 3.22.x release. So none is going to spend time to merge fix in gtk-3-22 branch... Anyway patch should apply cleanly there and probably even to older releases. Just ask your distro maintainer to add that patch. |
This hasn't been fixed. I got the updated version and tried running guake in mate-session on Debian testing and the results have been as before. In fact I saw even bugs.debian.org/916436 :( Will share the screenshot in a sec. |
With updated version you mean |
apparently the maintainer included the fix, at least that is what was told to me, although it doesn't appear in the debian changelog https://salsa.debian.org/gnome-team/gtk3/commit/0b26d0b56d5888d2c6a1244d41618e15dd6c3b2d |
It is different fix for different problem. You need this - https://gitlab.gnome.org/GNOME/gtk/merge_requests/451/. |
Package version you are waiting for will probably get a name like |
yup, shared it with the maintainer and he would also be looking for the new release as and when it's released. It's just waiting time I guess now :( |
well seems the new point release will be after Christmas as it's just one day before Christmas and didn't see any info. at least on mailing list to indicate they are going to make a new release soon :( |
Still no update :( https://gitlab.gnome.org/GNOME/gtk/tags |
apparently, the new version would be released sometime this week. https://mail.gnome.org/archives/gtk-devel-list/2019-January/msg00000.html |
Expected behaviour
Guake should show up in Notification area,
Actual behaviour
Guake should show up in Notification area, it doesn't.
Steps to reproduce the behaviour
I have no idea what is the problem, I did remove the upper panel and started afresh, when I put the notification area, I expected Guake to show up, it didn't, dunno why.
If I do use the mouse pointer to point exactly between notification area and qbittorrent I do get indication about guake .
This has been happening for quite sometime now.
![notification-area-no-guake](https://user-images.githubusercontent.com/727626/31133437-007958d4-a84f-11e7-9158-8669cdf61b16.png)
Linux Distribution
Debian Testing
Link to downstream report of your Distribution
bugs.debian.org/877638
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: