Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use full path to tray icon with libappindicator #591

Merged
merged 1 commit into from
Aug 1, 2015

Conversation

thwarted
Copy link
Contributor

@thwarted thwarted commented Aug 1, 2015

Resolve issue #433, broken tray icon when using python libappindicator bindings.

According to http://people.canonical.com/~ted/libappindicator/current/AppIndicator.html set_icon takes an "icon-name", which presumably is not actually intended to be a filename (?) Hard to tell. Giving it the full path works.

@thwarted
Copy link
Contributor Author

thwarted commented Aug 1, 2015

I found this example code that doesn't use a full path/filename to the icon file, but just a bare "name", so who knows what the intent is.

http://www.eurion.net/python-snippets/snippet/Create%20an%20Application%20Indicator.html

gsemet added a commit that referenced this pull request Aug 1, 2015
use full path to tray icon with libappindicator
@gsemet gsemet merged commit 2f3a252 into Guake:master Aug 1, 2015
@gsemet
Copy link
Member

gsemet commented Aug 1, 2015

ok thanks for this pl

@gsemet gsemet added this to the 0.8.0 milestone Aug 1, 2015
gsemet added a commit that referenced this pull request Jan 30, 2017
use full path to tray icon with libappindicator
gsemet added a commit that referenced this pull request Jan 30, 2017
use full path to tray icon with libappindicator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants