feat: add company signature form #159
Conversation
| @@ -1,7 +1,7 @@ | |||
| import { useTranslation } from 'react-i18next' | |||
|
|
|||
| export function Head() { | |||
| const { t } = useTranslation('Company.DocumentSigner') | |||
| const { t } = useTranslation('Company.DocumentList') | |||
There was a problem hiding this comment.
No idea what happened with these but there must have been some regression 😅 it has always been named DocumentList. This updates to fix
| /** | ||
| * TODO[GWS-3365]: This is a temporary value here until we resolve the correct way forward with the IP address | ||
| */ | ||
| signed_by_ip_address: '127.0.0.1', |
There was a problem hiding this comment.
This is something we still need to revisit. i think the consensus was that we just need to have them add the ip address via their proxy. Updated the ticket to generalize from employee document signing to company document signing
There was a problem hiding this comment.
This is probably not the solution but looks like there are a lot of tools out there that let you hit their API and they return your IP address. Maybe Gusto needs an endpoint like this? https://api.myip.com/
There was a problem hiding this comment.
@jeffredodd we're in the browser, so we don't have a way to enforce this in an ironclad way (anyone can tamper with the output)
potentially there could be a way forward with redesigning the server API to allow for some kind of signature/nonce but it's not reachable without some groupwork :)
serikjensen
force-pushed
the
feat/GWS-3682
branch
from
a09da42 to
5e50bd0
Compare
This adds a company signature form as seen in the figma here https://www.figma.com/design/6dxOSiONDiJoa9zY1wOwbs/Frontend-SDK-Partner-Design-File?node-id=5220-17986&m=dev
Proof of functionality
Signature form submitting correctly and firing an event with the sign form response
Screen.Recording.2025-02-20.at.4.13.55.PM.mov
Form updated to complete in the document list
Form validation behaving correctly
Screen.Recording.2025-02-20.at.4.15.22.PM.mov
Download functionality behaving as expected
Screen.Recording.2025-02-20.at.4.17.49.PM.mov
Event firing for back navigation
Screen.Recording.2025-02-20.at.4.18.52.PM.mov
Mobile view