chore: fix & elide typescript errors; error fail CI build #162
Conversation
| @@ -28,7 +28,7 @@ | |||
| "./CHANGELOG.md" | |||
| ], | |||
| "scripts": { | |||
| "build": "npm run build:clean && npm run generate && vite build", | |||
| "build": "npm run build:clean && npm run generate && npm run tsc && vite build", | |||
There was a problem hiding this comment.
This felt like the best place to insert the typecheck. Broken types won't break your local dev build while you're working but will break both CI and publish here. There's some room for efficiency to run tsc and vite in parallel here but didn't feel worth right now.
| @@ -1,6 +1,7 @@ | |||
| import { useTranslation } from 'react-i18next' | |||
|
|
|||
| export function Head() { | |||
| // @ts-expect-error HACK missing translations | |||
There was a problem hiding this comment.
@serikjensen Do you know if we can use Employee.DocumentSigner here or do we need to develop two sets of i18n files?
There was a problem hiding this comment.
no idea what happened here if it was a rename that didn't get updated, but for some reason it points to a file that doesn't exist. it should be
const { t } = useTranslation('Company.DocumentList')
I have a fix for it included in this PR #159 (comment)
i'm good with you just adding the comment here and then rebasing that signature form PR and fixing it there
| @@ -12,7 +12,7 @@ | |||
| "module": "ESNext", | |||
| "moduleDetection": "force", | |||
| "allowJs": true, | |||
| "noEmit": false, | |||
| "noEmit": true, | |||
There was a problem hiding this comment.
We don't actually compile with tsc, just typecheck. vite runs our compilation step via esbuild, so we can save some time/duplication by just telling tsc not to emit files.
| @@ -1,6 +1,7 @@ | |||
| import { useTranslation } from 'react-i18next' | |||
|
|
|||
| export function Head() { | |||
| // @ts-expect-error HACK missing translations | |||
There was a problem hiding this comment.
no idea what happened here if it was a rename that didn't get updated, but for some reason it points to a file that doesn't exist. it should be
const { t } = useTranslation('Company.DocumentList')
I have a fix for it included in this PR #159 (comment)
i'm good with you just adding the comment here and then rebasing that signature form PR and fixing it there
For simple typescript errors I fixed them inline.
For more complicated ones I added a
@ts-expect-errorfor us to go fix in a future PR so that we can get back to good as quickly as possible.