Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Packaging HDF5 1.14 references build directory in settings #2422

Closed
SMillerDev opened this issue Jan 30, 2023 · 1 comment · Fixed by #2667
Closed

[BUG] Packaging HDF5 1.14 references build directory in settings #2422

SMillerDev opened this issue Jan 30, 2023 · 1 comment · Fixed by #2667
Assignees
@jhendersonHDF @byrnHDF
Labels
Component - Build CMake, Autotools Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub

Comments

@SMillerDev
Copy link

Describe the bug
After 27bb358#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810 the hdf5 settings file references the directory hdf5 was build in.

Expected behavior
Includes should not reference a temporary build directory.

Platform (please complete the following information)

Additional context
This was discovered at Homebrew/homebrew-core#119504
@SMillerDev SMillerDev added the bug label Jan 30, 2023
@hmaarrfk hmaarrfk mentioned this issue Feb 8, 2023
Closed
1 task
@hmaarrfk
Copy link

hmaarrfk commented Feb 8, 2023

did you ever find a workaround for this?

@MicK7 MicK7 mentioned this issue Feb 8, 2023
Closed
@ndevenish ndevenish mentioned this issue Feb 8, 2023
Closed
This was referenced Feb 14, 2023
Merged
Closed
@jayghoshter jayghoshter mentioned this issue Feb 20, 2023
Closed
@derobins derobins removed the bug label Mar 3, 2023
@mattjala mattjala added Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub Component - Build CMake, Autotools labels Mar 7, 2023
This was referenced Mar 15, 2023
Merged
Merged
@jhendersonHDF jhendersonHDF mentioned this issue Mar 21, 2023
Closed
@rtburns-jpl rtburns-jpl mentioned this issue Mar 22, 2023
Merged
5 tasks
@Pesc0 Pesc0 mentioned this issue Mar 31, 2023
Closed
2 tasks
@brtnfld brtnfld added the Priority - 0. Blocker ⛔ This MUST be merged for the release to happen label Apr 5, 2023
jhendersonHDF added a commit to jhendersonHDF/hdf5 that referenced this issue Apr 5, 2023
@jhendersonHDF
Fix improper include of build directory (HDFGroup#2422, HDFGroup#2621)
5743c9b
@jhendersonHDF jhendersonHDF linked a pull request Apr 5, 2023 that will close this issue
Fix improper include of build directory (#2422, #2621) #2667
Merged
@brtnfld brtnfld mentioned this issue Apr 5, 2023
Merged
lrknox pushed a commit that referenced this issue Apr 11, 2023
@jhendersonHDF
Fix improper include of build directory (#2422, #2621) (#2667)
b77cb39
jhendersonHDF added a commit to jhendersonHDF/hdf5 that referenced this issue Apr 13, 2023
@jhendersonHDF
Fix improper include of build directory (HDFGroup#2422, HDFGroup#2621) (
68d7b07 
HDFGroup#2667)
brtnfld pushed a commit to brtnfld/hdf5 that referenced this issue Apr 13, 2023
@jhendersonHDF @brtnfld
Fix improper include of build directory (HDFGroup#2422, HDFGroup#2621) (
4dd48a9 
HDFGroup#2667)
derobins pushed a commit that referenced this issue Apr 13, 2023
@jhendersonHDF
Fix improper include of build directory (#2422, #2621) (#2667) (#2713)
02c6873
byrnHDF pushed a commit to byrnHDF/hdf5 that referenced this issue Apr 16, 2023
@jhendersonHDF @byrnHDF
Fix improper include of build directory (HDFGroup#2422, HDFGroup#2621) (
cb14934 
HDFGroup#2667)
brtnfld pushed a commit to brtnfld/hdf5 that referenced this issue May 17, 2023
@jhendersonHDF @brtnfld
Fix improper include of build directory (HDFGroup#2422, HDFGroup#2621) (
38404df 
HDFGroup#2667)
@diiigle diiigle mentioned this issue Jun 3, 2023
Closed
@minrk minrk mentioned this issue Jun 14, 2023
Merged
@divital-coder divital-coder mentioned this issue Mar 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhendersonHDF jhendersonHDF

@byrnHDF byrnHDF

Labels
Component - Build CMake, Autotools Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub
Projects
None yet
Milestone
No milestone
7 participants
@derobins @hmaarrfk @SMillerDev @brtnfld @jhendersonHDF @byrnHDF @mattjala