Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent editing of reports not in "Draft" or "Needs Action" mode #285

Closed
3 tasks
jasalisbury opened this issue Feb 9, 2021 · 0 comments · Fixed by #334
Closed
3 tasks

Prevent editing of reports not in "Draft" or "Needs Action" mode #285

jasalisbury opened this issue Feb 9, 2021 · 0 comments · Fixed by #334
Assignees
Labels
5 Story Points In epic 5 Issue is a child in the indicated parent epic V1.0 MVP Indicates the release version for the issue

Comments

@jasalisbury
Copy link
Contributor

jasalisbury commented Feb 9, 2021

As a specialist, I want my reports to not be editable after submitting for approval, so I can be sure of what the manager is approving


Once a report has been submitted we do not want that report to be editable (except for the managerNotes and the status field). This will ensure we don't get into a strange situation where a manager approves an incomplete report.

For more context https://gsa-tts.slack.com/archives/C017RJ4GEET/p1612543608107300

Acceptance Criteria:

  • Report fields are only editable by authors when the report is in "Draft" or "Needs Action" status. managerNotes and status can still be updated by the manager once the report has been submitted
  • Any automatic report updating/saving is only enabled when the report has a status of "Draft" or "Needs Action"
  • For submitted reports the review page for authors is updated to allow authors to revoke the submission moving the report back to "Draft"
@jasalisbury jasalisbury added In epic 5 Issue is a child in the indicated parent epic Post MVP Issues cut from the MVP scope labels Feb 9, 2021
@jasalisbury jasalisbury added V1.0 MVP Indicates the release version for the issue and removed Post MVP Issues cut from the MVP scope labels Feb 10, 2021
@marriej marriej added the 5 Story Points label Feb 16, 2021
@jasalisbury jasalisbury self-assigned this Feb 17, 2021
rahearn added a commit that referenced this issue Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 Story Points In epic 5 Issue is a child in the indicated parent epic V1.0 MVP Indicates the release version for the issue
Projects
None yet
2 participants